Continue support for sparse serialization of Nullable columns by amosbird · Pull Request #88999 · ClickHouse/ClickHouse

amosbird · 2025-10-26T11:36:04Z

Changelog category (leave one):

Performance Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Added support of sparse serialization for columns of Nullable type. This continues #44539.

Details

This PR continues the work from #44539 to extend sparse serialization support for Nullable columns.

…nd-44539

clickhouse-gh · 2025-10-26T11:36:32Z

Workflow [PR], commit [5ec8a84]

Summary: ❌

job_name	test_name	status	info
Stateless tests (arm_binary, parallel)		failure
	03735_excessive_buffer_flush	FAIL	cidb
Integration tests (amd_tsan, 2/6)		failure
	test_storage_s3_queue/test_parallel_inserts.py::test_parallel_inserts_with_failures[1]	FAIL	cidb, issue
BuzzHouse (amd_debug)		failure
	Logical error: 'Inconsistent AST formatting: the query:	FAIL	cidb, issue

amosbird · 2025-11-14T09:47:05Z

BuzzHouse (amd_debug)

2025.11.13 18:25:54.915568 [ 110 ] {49bb015f-e14c-498b-888e-664ecd6c397e} <Fatal> : Logical error: 'Inconsistent AST formatting: the query:
CREATE TABLE d0.t65 (`c0` String, `c1` Tuple) ENGINE = KeeperMap('/kfile65', 5290) PRIMARY KEY `c0.size`[2] AS a49
cannot parse query back from CREATE TABLE d0.`t65` (`c0` String, `c1` Tuple()) ENGINE = KeeperMap('/kfile65', 5290) PRIMARY KEY ((`c0.size`[2] AS `a49`));'.

amosbird · 2025-11-14T09:48:31Z

Stress test (arm_asan)

 [ 12960 ] {e3fd566a-e364-4289-a334-5dbacd50a9b4} <Fatal> : Logical error: \'Cannot finalize buffer after cancellation.\'.

#88724

…ialization compatibility

CurtizJ

Thank you! Looks good in general.

We also need to bump the version of the protocol and remove Sparse from the Nullable columns here for old clients. Otherwise, we break compatibility somehow like this:

SELECT s
FROM test_sparse

   ┌────s─┐
1. │ ᴺᵁᴸᴸ │
2. │ ᴺᵁᴸᴸ │
3. │ ᴺᵁᴸᴸ │
4. │ ᴺᵁᴸᴸ │
5. │ ᴺᵁᴸᴸ │
   └──────┘
Error on processing query: Code: 100. DB::Exception: Unknown packet 111 from server localhost:9000. (UNKNOWN_PACKET_FROM_SERVER) (version 25.12.1.1)

Please also add a compatibility test.

CurtizJ · 2025-11-24T22:38:20Z

src/DataTypes/Serializations/SerializationSparse.cpp

 struct DeserializeStateSparse : public ISerialization::DeserializeBinaryBulkState
 {
+    /// Column offsets from previous read.
+    ColumnPtr column_offsets;


I missed something. Why do we need to save offsets from the previous read now?

This ensures that SerializationSparse and SerializationSparseNullMap can share a common sparse offset.

src/Storages/MergeTree/MergeTreeSettings.cpp

tests/queries/0_stateless/02504_sparse_nullable_columns.sql.j2

Algunenano · 2025-12-09T15:40:13Z

src/DataTypes/Serializations/SerializationSparse.cpp

+    }
+
+    settings.path.pop_back();
+    return state_sparse.column_offsets->size() - old_size;


Seeing a crash here in HEAD:

2025.12.09 10:40:28.775269 [ 125 ] {} <Fatal> BaseDaemon: 2. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationSparse.cpp:216: DB::(anonymous namespace)::readOrGetCachedSparseOffsets(DB::ISerialization::DeserializeBinaryBulkSettings&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*, DB::(anonymous namespace)::DeserializeStateSparse&, unsigned long, unsigned long, unsigned long, unsigned long&, unsigned long&) @ 0x000000001a773898 2025.12.09 10:40:28.786233 [ 125 ] {} <Fatal> BaseDaemon: 3. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationSparse.cpp:400: DB::SerializationSparse::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const @ 0x000000001a773017 2025.12.09 10:40:28.847084 [ 125 ] {} <Fatal> BaseDaemon: 4.0. inlined from ./src/DataTypes/Serializations/SerializationNamed.cpp:86: DB::SerializationNamed::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const 2025.12.09 10:40:28.847165 [ 125 ] {} <Fatal> BaseDaemon: 4. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationTuple.cpp:811: DB::SerializationTuple::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const @ 0x000000001a79a77a

More crashes:

2025.12.09 19:46:14.844169 [ 125 ] {} <Fatal> BaseDaemon: Stack trace: 0x000000001a797a58 0x000000001a7971d7 0x000000001a7be93a 0x000000001d0c4f0b 0x000000001d081299 0x000000001d08b064 0x000000001d0c97c4 0x000000001d094185 0x000000001d0d470c 0x000000001d0d8483 0x000000001d0da2b1 0x000000001e0bca92 0x000000001da878c1 0x000000001daa4ddd 0x000000001da96f1b 0x000000001da9b083 0x00000000168501cb 0x0000000016857366 0x000000001684d31f 0x0000000016854b5a 0x00007cbb66081ac3 0x00007cbb661138c0 2025.12.09 19:46:14.854508 [ 125 ] {} <Fatal> BaseDaemon: 2. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationSparse.cpp:216: DB::(anonymous namespace)::readOrGetCachedSparseOffsets(DB::ISerialization::DeserializeBinaryBulkSettings&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*, DB::(anonymous namespace)::DeserializeStateSparse&, unsigned long, unsigned long, unsigned long, unsigned long&, unsigned long&) @ 0x000000001a797a58 2025.12.09 19:46:14.863077 [ 125 ] {} <Fatal> BaseDaemon: 3. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationSparse.cpp:400: DB::SerializationSparse::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const @ 0x000000001a7971d7 2025.12.09 19:46:14.874088 [ 125 ] {} <Fatal> BaseDaemon: 4.0. inlined from ./src/DataTypes/Serializations/SerializationNamed.cpp:86: DB::SerializationNamed::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const 2025.12.09 19:46:14.874088 [ 125 ] {} <Fatal> BaseDaemon: 4.0. inlined from ./src/DataTypes/Serializations/SerializationNamed.cpp:86: DB::SerializationNamed::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const 2025.12.09 19:46:14.884197 [ 125 ] {} <Fatal> BaseDaemon: 5.0. inlined from ./ci/tmp/build/./src/Storages/MergeTree/MergeTreeReaderWide.cpp:573: DB::MergeTreeReaderWide::readData(DB::NameAndTypePair const&, std::shared_ptr<DB::ISerialization const> const&, COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, bool, unsigned long, unsigned long, unsigned long, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>&, std::unordered_map<String, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>>>>&) 2025.12.09 19:46:14.884264 [ 125 ] {} <Fatal> BaseDaemon: 5. ./ci/tmp/build/./src/Storages/MergeTree/MergeTreeReaderWide.cpp:184: DB::MergeTreeReaderWide::readRows(unsigned long, unsigned long, bool, unsigned long, unsigned long, std::vector<COW<DB::IColumn>::immutable_ptr<DB::IColumn>, std::allocator<COW<DB::IColumn>::immutable_ptr<DB::IColumn>>>&) @ 0x000000001d0c4f0b 2025.12.09 19:46:14.898525 [ 125 ] {} <Fatal> BaseDaemon: 6.0. inlined from ./ci/tmp/build/./src/Storages/MergeTree/MergeTreeRangeReader.cpp:130: DB::MergeTreeRangeReader::DelayedStream::readRows(std::vector<COW<DB::IColumn>::immutable_ptr<DB::IColumn>, std::allocator<COW<DB::IColumn>::immutable_ptr<DB::IColumn>>>&, unsigned long) 2025.12.09 19:46:14.898592 [ 125 ] {} <Fatal> BaseDaemon: 6. ./ci/tmp/build/./src/Storages/MergeTree/MergeTreeRangeReader.cpp:202: DB::MergeTreeRangeReader::DelayedStream::finalize(std::vector<COW<DB::IColumn>::immutable_ptr<DB::IColumn>, std::allocator<COW<DB::IColumn>::immutable_ptr<DB::IColumn>>>&) @ 0x000000001d081299 ...

Thanks for reporting this. Where can I find the full log that includes the crash?

Let me try to get a sample without private information of both the stacktrace and query logs

Cool. BTW, is there any crash report in the public repo for this issue? It seems this patch was merged 10 days ago. Did the first crash only appear yesterday?

I've been able to extract enough information to investigate this issue. One thing that I see in the servers after the crash are failures to merge:

2025.12.09 19:46:45.329702 [ 943 ] {} <Error> default.enriched_identities (824ad30d-b455-47a7-a508-16cd3a13df66): Part data/824ad30d-b455-47a7-a508-16cd3a13df66/all_0_0_1/ is broken and needs manual correction. Reason: Code: 226. DB::Exception: No stream (BaseIdentity%2EdeletedAt. sparse.idx.bin) file checksum for column BaseIdentity in part data/824ad30d-b455-47a7-a508-16cd3a13df66/all_0_0_1/: name: all_0_0_1, parent_part_name: , getMarkSizeInBytes: 24, getMarksCount: 60, index_granularity_info: [mark_type: [adaptive: true, compressed: true, with_substream s: false, part_type: Wide], index_granularity_bytes: 10485760, fixed_index_granularity: 8192], index_granularity: [Adaptive(marks_rows_partial_sums: [5651, 11921, 18112, 24142, 29452, 34420, 39278, 44051, 48667, 51768, 56989, 63417, 70956, 78489, 86020, 93429, 100550, 107805, 1159 97, 124189, 132381, 140573, 148765, 155021, 160516, 166697, 172337, 176661, 181261, 185961, 191301, 196037, 199925, 203410, 206096, 211602, 216275, 221730, 227526, 233764, 238714, 243204, 247557, 251911, 256368, 260970, 265350, 270115, 276227, 282439, 288643, 294849, 301059, 30726 5, 313478, 319696, 326751, 333827, 338641, 338641])], part_state: [type: Wide, state: Temporary, is_unexpected_local_part: false, is_frozen: false, is_duplicate: false, is_temp: false]. (NO_FILE_IN_DATA_PART), Stack trace (when copying this message, always include the lines below)

DeletedAt is declared as deletedAt Nullable(String) and it seems to be using the sparse type.

Also, shouldn't this serialization be off by default / based on compatiblity? I guess it's not compatible with previous releases, so the moment it's used all servers must be able to read it.

I've asked for help from the QA team to find a repro (and something without internal schemas or data, which I'm yet trying to figure out what can be shared or not).

Also, shouldn't this serialization be off by default / based on compatiblity? I guess it's not compatible with previous releases, so the moment it's used all servers must be able to read it.

It's likely because we enable randomization on this setting.

ClickHouse/tests/clickhouse-test

Line 1262 in 7d0b74a

"nullable_serialization_version": lambda: random.choice(["basic", "allow_sparse"]),

AFAICT no, nullable_serialization_version is not randomized or used on those test services, but it appears like it's being used anyway.

I'm not sure if it's related, but it seems they might comer from using tuples:

2025.12.09 19:46:10.292075 [ 125 ] {} <Fatal> BaseDaemon: 2. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationSparse.cpp:216: DB::(anonymous namespace)::readOrGetCachedSparseOffsets(DB::ISerialization::DeserializeBinaryBulkSettings&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*, DB::(anonymous namespace)::DeserializeStateSparse&, unsigned long, unsigned long, unsigned long, unsigned long&, unsigned long&) @ 0x000000001a797a58 2025.12.09 19:46:10.301328 [ 125 ] {} <Fatal> BaseDaemon: 3. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationSparse.cpp:400: DB::SerializationSparse::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const @ 0x000000001a7971d7 2025.12.09 19:46:10.325054 [ 125 ] {} <Fatal> BaseDaemon: 4.0. inlined from ./src/DataTypes/Serializations/SerializationNamed.cpp:86: DB::SerializationNamed::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const 2025.12.09 19:46:10.325118 [ 125 ] {} <Fatal> BaseDaemon: 4. ./ci/tmp/build/./src/DataTypes/Serializations/SerializationTuple.cpp:811: DB::SerializationTuple::deserializeBinaryBulkWithMultipleStreams(COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, unsigned long, DB::ISerialization::DeserializeBinaryBulkSettings&, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>&, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>*) const @ 0x000000001a7be93a 2025.12.09 19:46:10.345102 [ 125 ] {} <Fatal> BaseDaemon: 5.0. inlined from ./ci/tmp/build/./src/Storages/MergeTree/MergeTreeReaderWide.cpp:573: DB::MergeTreeReaderWide::readData(DB::NameAndTypePair const&, std::shared_ptr<DB::ISerialization const> const&, COW<DB::IColumn>::immutable_ptr<DB::IColumn>&, unsigned long, bool, unsigned long, unsigned long, unsigned long, std::unordered_map<String, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::unique_ptr<DB::ISerialization::ISubstreamsCacheElement, std::default_delete<DB::ISerialization::ISubstreamsCacheElement>>>>>&, std::unordered_map<String, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>, std::hash<String>, std::equal_to<String>, std::allocator<std::pair<String const, std::shared_ptr<DB::ISerialization::DeserializeBinaryBulkState>>>>&)

I wonder if some default is wrong somewhere

Interesting. I'll investigate.

I’ve successfully reproduced the tuple sparse/nullable inconsistency. I’ll prepare and submit a fix later today.

CREATE TABLE t (id UInt64, n Nullable(UInt64), s Nullable(String), t Tuple(a Nullable(String), b Nullable(UInt64))) ENGINE = MergeTree ORDER BY () SETTINGS index_granularity = 10, min_bytes_for_wide_part = 0, ratio_of_defaults_for_sparse_serialization = 0.1, serialization_info_version = 'with_types', nullable_serialization_version = 'basic'; insert into t(id) values (1), (2), (3); SELECT column, substreams FROM system.parts_columns WHERE (database = currentDatabase()) AND (`table` = 't') AND active; ┌─column─┬─substreams────────────────────────────────────────────────────────────────────────┐ 1. │ id │ ['id'] │ 2. │ n │ ['n.null','n'] │ 3. │ s │ ['s.null','s'] │ 4. │ t │ ['t%2Ea.sparse.idx','t%2Ea.null','t%2Ea','t%2Eb.sparse.idx','t%2Eb.null','t%2Eb'] │ └────────┴───────────────────────────────────────────────────────────────────────────────────┘

This reverts commit 8cbd360, reversing changes made to e72343b.

CurtizJ and others added 12 commits December 23, 2022 16:16

support of sparse nullable columns (wip)

d41e47c

fix sum of sparse nullable columns

67a20e9

slightly optimize aggregation of sparse nullable columns

8bf9903

Merge remote-tracking branch 'upstream/master' into HEAD

c28aae7

fix bad_cast with sparse columns

137a4f3

Merge branch 'master' into sparse-nullable-column

75d72e8

Merge remote-tracking branch 'upstream/master' into HEAD

4be6aa5

add comments

c07ce5f

Merge branch 'master' into sparse-nullable-column

a2b5404

Merge branch 'master' into sparse-nullable-column

0af6070

Merge remote-tracking branch 'curtizj/sparse-nullable-column' into co…

d306816

…nd-44539

Try new implementation

0ae2351

clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Oct 26, 2025

CurtizJ self-assigned this Oct 26, 2025

amosbird added 6 commits October 27, 2025 15:00

Fix tests

3c9d973

Fix more tests

496c80b

Fix another test

1a23149

Merge remote-tracking branch 'upstream/master' into cond-44539

67a6ff7

Merge remote-tracking branch 'upstream/master' into cond-44539

9a0f4c9

Merge branch 'master' into cond-44539

55f8f84

amosbird added 3 commits November 23, 2025 16:33

Merge branch 'master' into cond-44539

dafac4f

Merge remote-tracking branch 'upstream/master' into cond-44539

ef42277

Add nullable_serialization_version setting to control Nullable(T) ser…

2f72b0f

…ialization compatibility

amosbird force-pushed the cond-44539 branch from 65a26ad to 2f72b0f Compare November 24, 2025 14:58

Fix copy-paste error

89ababa

CurtizJ reviewed Nov 24, 2025

View reviewed changes

Add backward compatibility

5c9d64a

amosbird and others added 3 commits November 27, 2025 15:13

Fix test

f427d6b

Merge remote-tracking branch 'upstream/master' into cond-44539

9351639

fix settings history

5ec8a84

CurtizJ added this pull request to the merge queue Nov 30, 2025

Merged via the queue into ClickHouse:master with commit 8cbd360 Nov 30, 2025
126 of 130 checks passed

robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 30, 2025

Algunenano reviewed Dec 9, 2025

View reviewed changes

Algunenano added a commit to Algunenano/ClickHouse that referenced this pull request Dec 10, 2025

Revert "Merge pull request ClickHouse#88999 from amosbird/cond-44539"

b78c33d

This reverts commit 8cbd360, reversing changes made to e72343b.

This was referenced Dec 10, 2025

Revert "Merge pull request #88999 from amosbird/cond-44539" #91851

Closed

Sparse serialization should be supported for Nullable #64083

Closed

Algunenano added a commit to Algunenano/ClickHouse that referenced this pull request Dec 10, 2025

Revert "Merge pull request ClickHouse#88999 from amosbird/cond-44539"

8e03d76

This reverts commit 8cbd360, reversing changes made to e72343b.

Algunenano mentioned this pull request Dec 10, 2025

Fix segfault with sparse values in NULL #91738

Closed

1 task

PedroTadim mentioned this pull request Dec 11, 2025

Logical error: 'Bad cast from type DB::ColumnVector<unsigned long> to DB::ColumnString' with Squashing #91380

Closed

amosbird mentioned this pull request Dec 12, 2025

Fix sparse deserialization errors for virtual subcolumns (e.g., string size) #92060

Closed

1 task

alexey-milovidov added pr-performance Pull request with some performance improvements and removed pr-improvement Pull request with some product improvements labels Dec 18, 2025

fm4v mentioned this pull request Dec 23, 2025

Logical error: Column 'col1 Int64 Sparse(size = 0, Nullable(size = 1, Int64(size = 1), UInt8(size = 1)), UInt64(size = 0))' is expected to be nullable #92920

Closed

Conversation

amosbird commented Oct 26, 2025 • edited by alexey-milovidov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Details

Uh oh!

clickhouse-gh bot commented Oct 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

amosbird commented Nov 14, 2025

Uh oh!

amosbird commented Nov 14, 2025

Uh oh!

CurtizJ left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

amosbird commented Oct 26, 2025 •

edited by alexey-milovidov

Loading

clickhouse-gh bot commented Oct 26, 2025 •

edited

Loading

CurtizJ left a comment •

edited

Loading