Skip to content

Forbid setting temporary_files_buffer_size=0#88917

Merged
PedroTadim merged 4 commits intomasterfrom
vdimir/issue_88900
Nov 27, 2025
Merged

Forbid setting temporary_files_buffer_size=0#88917
PedroTadim merged 4 commits intomasterfrom
vdimir/issue_88900

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Oct 23, 2025 •
edited by clickhouse-gh bot
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Throw exception when temporary_files_buffer_size is set to 0. Resolves #88900

Details

Resolves #88900

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 23, 2025 •
edited
Loading

Workflow [PR], commit [0cd4867]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
03514_grace_hash_join_logical_error FAIL cidb
BuzzHouse (amd_debug) failure
Buzzing result failure cidb

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Oct 23, 2025
PedroTadim
PedroTadim reviewed Oct 23, 2025
View reviewed changes
@PedroTadim PedroTadim enabled auto-merge October 24, 2025 07:15
@vdimir vdimir force-pushed the vdimir/issue_88900 branch 2 times, most recently from 0d8a60b to 4341827 Compare October 28, 2025 12:50
@vdimir vdimir mentioned this pull request Oct 28, 2025
Merged
1 task
vdimir
vdimir commented Oct 28, 2025
View reviewed changes
@vdimir vdimir force-pushed the vdimir/issue_88900 branch from 1c8b6be to f17f7ad Compare November 3, 2025 09:24
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Nov 17, 2025

failure Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel)

#90174

vdimir
vdimir commented Nov 17, 2025
View reviewed changes
@PedroTadim
Copy link
Copy Markdown
Member

PedroTadim commented Nov 27, 2025

Can this PR be merged?

@PedroTadim PedroTadim added this pull request to the merge queue Nov 27, 2025
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Nov 27, 2025

Can this PR be merged?

Yes, I think finally we can merge. There was so many unrealted failures in this or sync PR CI so it took so much time 😕

Merged via the queue into master with commit 99b3242 Nov 27, 2025
507 of 516 checks passed
@PedroTadim PedroTadim deleted the vdimir/issue_88900 branch November 27, 2025 14:51
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 27, 2025
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 27, 2025
This was referenced Nov 27, 2025
Closed
Closed
This was referenced Nov 27, 2025
Closed
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Nov 27, 2025
@robot-ch-test-poll3
Merge pull request #90992 from ClickHouse/cherrypick/25.11/88917
d2afe38 
Cherry pick #88917 to 25.11: Forbid setting temporary_files_buffer_size=0
robot-clickhouse added a commit that referenced this pull request Nov 27, 2025
@robot-clickhouse
Backport #88917 to 25.11: Forbid setting temporary_files_buffer_size=0
66b731c
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Nov 27, 2025
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Nov 27, 2025
@robot-ch-test-poll2
Merge pull request #90991 from ClickHouse/cherrypick/25.10/88917
4c16b40 
Cherry pick #88917 to 25.10: Forbid setting temporary_files_buffer_size=0
robot-clickhouse added a commit that referenced this pull request Nov 27, 2025
@robot-clickhouse
Backport #88917 to 25.10: Forbid setting temporary_files_buffer_size=0
6dfb057
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Nov 27, 2025
Closed
clickhouse-gh bot added a commit that referenced this pull request Nov 27, 2025
@clickhouse-gh
Merge pull request #90993 from ClickHouse/backport/25.11/88917
67f55fd 
Backport #88917 to 25.11: Forbid setting temporary_files_buffer_size=0
vdimir added a commit that referenced this pull request Nov 27, 2025
@vdimir
Revert "Backport #88917 to 25.11: Forbid setting temporary_files_buff…
233aa45 
…er_size=0"
@vdimir vdimir mentioned this pull request Nov 27, 2025
Closed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PedroTadim PedroTadim PedroTadim approved these changes

Assignees

@PedroTadim PedroTadim

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't set temporary_files_buffer_size to 0 (SEGV)

6 participants

@vdimir @PedroTadim @alexey-milovidov @robot-ch-test-poll1 @robot-ch-test-poll4 @robot-clickhouse-ci-1