Skip to content

Catch exceptions when async logging fails to prevent program aborts#88814

Merged
Algunenano merged 1 commit intoClickHouse:masterfrom
Algunenano:async_exception
Oct 21, 2025
Merged

Catch exceptions when async logging fails to prevent program aborts#88814
Algunenano merged 1 commit intoClickHouse:masterfrom
Algunenano:async_exception

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Oct 20, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Catch exceptions when async logging fails to prevent program aborts

If there is a disk failure when logging, the async threads did not catch the exception and the program aborted.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 20, 2025 •
edited
Loading

Workflow [PR], commit [d330cf0]

Summary: ❌

job_name test_name status info comment
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Oct 20, 2025
@Algunenano Algunenano mentioned this pull request Oct 20, 2025
Merged
@azat azat self-assigned this Oct 20, 2025
@Algunenano Algunenano enabled auto-merge October 21, 2025 07:42
@Algunenano Algunenano added this pull request to the merge queue Oct 21, 2025
Merged via the queue into ClickHouse:master with commit 44e9277 Oct 21, 2025
121 of 123 checks passed
@Algunenano Algunenano deleted the async_exception branch October 21, 2025 08:17
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 21, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Oct 21, 2025
This was referenced Oct 21, 2025
Closed
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Oct 21, 2025
@robot-ch-test-poll4
Merge pull request #88832 from ClickHouse/cherrypick/25.7/88814
0dd68e8 
Cherry pick #88814 to 25.7: Catch exceptions when async logging fails to prevent program aborts
robot-clickhouse added a commit that referenced this pull request Oct 21, 2025
@robot-clickhouse
Backport #88814 to 25.7: Catch exceptions when async logging fails to…
bcaf181 
… prevent program aborts
This was referenced Oct 21, 2025
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Oct 21, 2025
@robot-ch-test-poll4
Merge pull request #88834 from ClickHouse/cherrypick/25.8/88814
ae4ba99 
Cherry pick #88814 to 25.8: Catch exceptions when async logging fails to prevent program aborts
robot-clickhouse added a commit that referenced this pull request Oct 21, 2025
@robot-clickhouse
Backport #88814 to 25.8: Catch exceptions when async logging fails to…
c37f56c 
… prevent program aborts
This was referenced Oct 21, 2025
Merged
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Oct 21, 2025
@robot-ch-test-poll4
Merge pull request #88836 from ClickHouse/cherrypick/25.9/88814
bffc8d4 
Cherry pick #88814 to 25.9: Catch exceptions when async logging fails to prevent program aborts
robot-clickhouse added a commit that referenced this pull request Oct 21, 2025
@robot-clickhouse
Backport #88814 to 25.9: Catch exceptions when async logging fails to…
1aec2bc 
… prevent program aborts
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Oct 21, 2025
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 21, 2025
clickhouse-gh bot added a commit that referenced this pull request Oct 21, 2025
@clickhouse-gh
Merge pull request #88833 from ClickHouse/backport/25.7/88814
c38db28 
Backport #88814 to 25.7: Catch exceptions when async logging fails to prevent program aborts
clickhouse-gh bot added a commit that referenced this pull request Oct 21, 2025
@clickhouse-gh
Merge pull request #88837 from ClickHouse/backport/25.9/88814
08afb4f 
Backport #88814 to 25.9: Catch exceptions when async logging fails to prevent program aborts
Algunenano added a commit that referenced this pull request Oct 21, 2025
@Algunenano
Merge pull request #88835 from ClickHouse/backport/25.8/88814
0da2a01 
Backport #88814 to 25.8: Catch exceptions when async logging fails to prevent program aborts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat approved these changes

Assignees

@azat azat

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Algunenano @azat @nikitamikhaylov @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-clickhouse-ci-2