Skip to content

Not support transaction for tables with disks which do not support writing with append.#88490

Merged
tuanpach merged 4 commits intoClickHouse:masterfrom
tuanpach:not-support-transaction-for-non-append-supporting-disks
Nov 3, 2025
Merged

Not support transaction for tables with disks which do not support writing with append.#88490
tuanpach merged 4 commits intoClickHouse:masterfrom
tuanpach:not-support-transaction-for-non-append-supporting-disks

Conversation

@tuanpach
Copy link
Copy Markdown
Member

@tuanpach tuanpach commented Oct 14, 2025

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

For MergeTree tables using object storage which do not support writing with append, it will not support transactions. Closes #84669

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Directly edit documentation source files in the "docs" folder with the same pull-request as code changes

or

Add a user-readable short description of the changes that should be added to docs.clickhouse.com below.

At a minimum, the following information should be added (but add more as needed).

  • Motivation: Why is this function, table engine, etc. useful to ClickHouse users?

  • Parameters: If the feature being added takes arguments, options or is influenced by settings, please list them below with a brief explanation.

  • Example use: A query or command.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 14, 2025

Workflow [PR], commit [c627b0c]

Summary:

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, sequential) failure
01079_parallel_alter_detach_table_zookeeper FAIL cidb
Integration tests (amd_asan, old analyzer, 4/6) failure
test_log_query_probability/test.py::test_log_quries_probability_two FAIL cidb

@clickhouse-gh clickhouse-gh bot added the pr-ci label Oct 14, 2025
@tuanpach tuanpach force-pushed the not-support-transaction-for-non-append-supporting-disks branch 2 times, most recently from f638fd7 to 569edb9 Compare October 14, 2025 07:19
@antaljanosbenjamin antaljanosbenjamin self-assigned this Oct 14, 2025
@tuanpach tuanpach force-pushed the not-support-transaction-for-non-append-supporting-disks branch 2 times, most recently from 732fc2a to 3137879 Compare October 30, 2025 03:08
@tuanpach tuanpach force-pushed the not-support-transaction-for-non-append-supporting-disks branch from 9057cac to 3e8f8e4 Compare October 30, 2025 05:50
@tuanpach
Copy link
Copy Markdown
Member Author

01079_parallel_alter_detach_table_zookeeper

test_log_query_probability/test.py::test_log_quries_probability_two

@tuanpach tuanpach added this pull request to the merge queue Nov 3, 2025
Merged via the queue into ClickHouse:master with commit 183db0d Nov 3, 2025
121 of 124 checks passed
@tuanpach tuanpach deleted the not-support-transaction-for-non-append-supporting-disks branch November 3, 2025 11:52
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 3, 2025
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request Mar 4, 2026
…tion-for-non-append-supporting-disks

Not support transaction for tables with disks which do not support writing with append.
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request Mar 4, 2026
…tion-for-non-append-supporting-disks

Not support transaction for tables with disks which do not support writing with append.
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request Mar 4, 2026
…tion-for-non-append-supporting-disks

Not support transaction for tables with disks which do not support writing with append.

Signed-off-by: Anton Ivashkin <ianton@live.com>
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stress test fails with Disk does not support WriteMode::Append

3 participants