Skip to content

Fix logical error in cross join reordering#88286

Merged
vdimir merged 2 commits intomasterfrom
vdimir/join_order_mixed_comma_and_left
Nov 4, 2025
Merged

Fix logical error in cross join reordering#88286
vdimir merged 2 commits intomasterfrom
vdimir/join_order_mixed_comma_and_left

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Oct 9, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Details

Followup for #88151

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 9, 2025 •
edited
Loading

Workflow [PR], commit [5de832f]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_debug, AsyncInsert, s3 storage, parallel) failure
02572_materialized_views_ignore_errors FAIL cidb
Stateless tests (amd_ubsan, sequential) failure
02346_text_index_hits FAIL cidb
Docker keeper image failure
clickhouse/clickhouse-keeper:head-amd64 failure cidb

@vdimir vdimir requested a review from davenger October 9, 2025 11:40
@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 9, 2025
@devcrafter
Copy link
Copy Markdown
Member

devcrafter commented Oct 13, 2025

Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) - should be fixed by #88465

devcrafter
devcrafter reviewed Oct 14, 2025
View reviewed changes
tests/queries/0_stateless/03644_join_order_mixed_comma_and_left.sql Outdated
@@ -1,3 +1,5 @@
SET enable_parallel_replicas = 0;
Copy link
Copy Markdown
Member

@devcrafter devcrafter Oct 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. Having the test in blacklist should be enough. I'll exclude the test from blacklist as soon as #88465 will be merged (or wait until it merged - trying to do this today)

vdimir
vdimir commented Oct 16, 2025
View reviewed changes
vdimir
vdimir commented Oct 16, 2025
View reviewed changes
@vdimir vdimir force-pushed the vdimir/join_order_mixed_comma_and_left branch from e414cc5 to 17bafaf Compare November 3, 2025 12:54
@clickhouse-gh clickhouse-gh bot added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Nov 3, 2025
@vdimir vdimir force-pushed the vdimir/join_order_mixed_comma_and_left branch from 17bafaf to e3c4813 Compare November 3, 2025 13:07
@vdimir vdimir enabled auto-merge November 3, 2025 14:28
@vdimir vdimir mentioned this pull request Nov 3, 2025
Closed
@vdimir vdimir added this pull request to the merge queue Nov 4, 2025
@vdimir
Copy link
Copy Markdown
Member Author

vdimir commented Nov 4, 2025

Stateless tests (amd_debug, AsyncInsert, s3 storage, parallel)
Stateless tests (amd_ubsan, sequential)

02572_materialized_views_ignore_errors and 02346_text_index_hits are flaky

Docker keeper image

Merged via the queue into master with commit 34074c0 Nov 4, 2025
121 of 125 checks passed
@vdimir vdimir deleted the vdimir/join_order_mixed_comma_and_left branch November 4, 2025 13:43
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 4, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Nov 4, 2025
@robot-clickhouse robot-clickhouse mentioned this pull request Nov 4, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Nov 4, 2025
@robot-clickhouse
Merge pull request #89507 from ClickHouse/cherrypick/25.10/88286
96cdb6d 
Cherry pick #88286 to 25.10: Fix logical error in cross join reordering
robot-clickhouse added a commit that referenced this pull request Nov 4, 2025
@robot-clickhouse
Backport #88286 to 25.10: Fix logical error in cross join reordering
950483e
@robot-clickhouse robot-clickhouse mentioned this pull request Nov 4, 2025
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 4, 2025
vdimir added a commit that referenced this pull request Nov 5, 2025
@vdimir
Merge pull request #89508 from ClickHouse/backport/25.10/88286
a61ead2 
Backport #88286 to 25.10: Fix logical error in cross join reordering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter left review comments

@davenger davenger davenger approved these changes

Assignees

@davenger davenger

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.10-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LOGICAL_ERROR "Join restriction violated"

6 participants

@vdimir @devcrafter @davenger @robot-ch-test-poll1 @robot-ch-test-poll4 @robot-clickhouse-ci-2