Skip to content

Add logs to S3 Client#88001

Merged
nikitamikhaylov merged 7 commits intoClickHouse:masterfrom
jkartseva:s3-client-more-logs
Oct 2, 2025
Merged

Add logs to S3 Client#88001
nikitamikhaylov merged 7 commits intoClickHouse:masterfrom
jkartseva:s3-client-more-logs

Conversation

@jkartseva
Copy link
Copy Markdown
Member

@jkartseva jkartseva commented Oct 2, 2025

Log examples

2025.10.02 02:03:43.170629 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 1/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:43.170664 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 109 ms
2025.10.02 02:03:43.286650 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 2/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:43.286679 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 212 ms
2025.10.02 02:03:43.504948 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 3/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:43.504976 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 432 ms
2025.10.02 02:03:43.943802 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 4/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:43.943830 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 862 ms
2025.10.02 02:03:44.828591 [ 1612 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 5/11 succeeded with response code 200, last error: 503, Slow Down.
2025.10.02 02:03:44.904419 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 1/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:44.904479 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 100 ms
2025.10.02 02:03:45.015932 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 2/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:45.015965 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 207 ms
2025.10.02 02:03:45.231232 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 3/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:45.231270 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 418 ms
2025.10.02 02:03:45.655874 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 4/11 failed with retryable error: 503, Slow Down.
2025.10.02 02:03:45.655913 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Test> S3ClientRetryStrategy: Next retry in 857 ms
2025.10.02 02:03:46.541072 [ 1620 ] {f03ce81e483747e6a8936d8492b73c10} <Trace> S3ClientRetryStrategy: Attempt 5/11 succeeded with response code 200, last error: 503, Slow Down.

2025.10.02 02:22:52.540450 [ 756 ] {} <Trace> S3Client: S3 client for disk 'disk_s3' initialized with s3_retry_attempts: 100
2025.10.02 02:22:52.540452 [ 756 ] {} <Trace> S3Client: S3 client for disk 'disk_s3': slowing down threads on retryable errors is disabled

2025.10.02 02:25:34.132836 [ 1600 ] {a26fc691a87441128fd5905edd3d6d43} <Trace> S3Client: S3 client initialized with s3_retry_attempts: 1000
2025.10.02 02:25:34.132837 [ 1600 ] {a26fc691a87441128fd5905edd3d6d43} <Trace> S3Client: S3 client: slowing down threads on retryable errors is disabled

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Oct 2, 2025 •
edited
Loading

Workflow [PR], commit [7e8c6bb]

Summary: ✅

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 2, 2025
@jkartseva jkartseva force-pushed the s3-client-more-logs branch from ef0298c to 879cc85 Compare October 2, 2025 03:04
@evillique evillique self-assigned this Oct 2, 2025
@nikitamikhaylov nikitamikhaylov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 2, 2025
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Oct 2, 2025
Merged via the queue into ClickHouse:master with commit 15c6050 Oct 2, 2025
241 of 242 checks passed
@robot-clickhouse robot-clickhouse added pr-synced-to-cloud The PR is synced to the cloud repo pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Oct 2, 2025
This was referenced Oct 2, 2025
Closed
Closed
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Oct 2, 2025
@robot-clickhouse-ci-2
Merge pull request #88022 from ClickHouse/cherrypick/25.8/88001
994b0fc 
Cherry pick #88001 to 25.8: Add logs to S3 Client
robot-clickhouse added a commit that referenced this pull request Oct 2, 2025
@robot-clickhouse
Backport #88001 to 25.8: Add logs to S3 Client
23e2760
This was referenced Oct 2, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Oct 2, 2025
@robot-clickhouse-ci-2
Merge pull request #88024 from ClickHouse/cherrypick/25.9/88001
c28014c 
Cherry pick #88001 to 25.9: Add logs to S3 Client
robot-clickhouse added a commit that referenced this pull request Oct 2, 2025
@robot-clickhouse
Backport #88001 to 25.9: Add logs to S3 Client
c94f7fa
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Oct 2, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Oct 2, 2025
@clickhouse-gh
Merge pull request #88025 from ClickHouse/backport/25.9/88001
a9073a4 
Backport #88001 to 25.9: Add logs to S3 Client
nikitamikhaylov added a commit that referenced this pull request Oct 2, 2025
@nikitamikhaylov
Merge pull request #88023 from ClickHouse/backport/25.8/88001
d5d5b9f 
Backport #88001 to 25.8: Add logs to S3 Client
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 2, 2025
@george-larionov george-larionov mentioned this pull request Nov 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkartseva @nikitamikhaylov @evillique @robot-clickhouse @robot-ch-test-poll4