Conversation
This comment was marked as resolved.
This comment was marked as resolved.
scanhex12
reviewed
Sep 18, 2025
tests/integration/test_storage_iceberg_with_spark/test_position_deletes.py
Outdated
Show resolved
Hide resolved
divanik
reviewed
Sep 19, 2025
src/Storages/ObjectStorage/DataLakes/Iceberg/PositionDeleteTransform.cpp
Outdated
Show resolved
Hide resolved
src/Storages/ObjectStorage/DataLakes/Iceberg/PositionDeleteTransform.cpp
Show resolved
Hide resolved
divanik
approved these changes
Sep 29, 2025
mkmkme
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Nov 13, 2025
Fixes for parquet reader v3, _row_number, and iceberg positioned deletes
25 tasks
Enmk
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Nov 17, 2025
Antalya 25.8 Backport of ClickHouse#87220 - Fixes for parquet reader v3, _row_number, and iceberg positioned deletes
Ted-Jiang
reviewed
Jan 20, 2026
| /// worth the added complexity. | ||
| for (size_t i = 0; i < max_threads; ++i) | ||
| { | ||
| pool->scheduleOrThrowOnError([this] { threadFunction(); }); |
Contributor
There was a problem hiding this comment.
scheduleOrThrow: always throws when the task cannot be enqueued (queue full, pool stopped, etc.).
scheduleOrThrowOnError :only throws on genuine scheduling errors; if the pool is already stopping/finished, it simply skips scheduling without throwing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fixed logical errors in
_row_numbervirtual column and iceberg positioned deletes._row_numbervirtual column)._row_numbervirtual column was broken in a simple way and untested.IcebergStreamingPositionDeleteTransformexpected the input chunks to arrive in order of increasing row number, but parquet readers didn't guarantee this. Made iceberg reader enableinput_format_parquet_preserve_orderifuse_roaring_bitmap_iceberg_positional_deletesis false.input_format_parquet_preserve_orderimplementation to not be slow. I previously planned to deprecate and delete it instead, but I guess we can't, since it's used in iceberg.