Fix simple parquet reader v3 assert on bool column min/max#87095
Merged
alexey-milovidov merged 3 commits intomasterfrom Oct 19, 2025
Merged
Fix simple parquet reader v3 assert on bool column min/max#87095alexey-milovidov merged 3 commits intomasterfrom
alexey-milovidov merged 3 commits intomasterfrom
Conversation
Contributor
PedroTadim
reviewed
Sep 14, 2025
| UInt64 val = 0; | ||
| switch (input_size) | ||
| { | ||
| case 1: val = unalignedLoad<UInt8>(data.data()); break; |
Member
There was a problem hiding this comment.
Should you add the 2-byte (ie UInt16) case as well?
Member
Author
There was a problem hiding this comment.
It's not used since the only int parquet physical types are BOOLEAN, INT32, and INT64. But ok, added just in case the reader of the code has OCD :)
alexey-milovidov
approved these changes
Oct 18, 2025
mkmkme
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Jan 7, 2026
Fix simple parquet reader v3 assert on bool column min/max
25 tasks
zvonand
added a commit
to Altinity/ClickHouse
that referenced
this pull request
Jan 15, 2026
Antalya 25.8 Backport of ClickHouse#87095 - Fix simple parquet reader v3 assert on bool column min/max
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Closes #87078
Some code assigned
input_signed = 1, some other code didn't expect that value.