Skip to content

Fix missing column definer in system.tables#86295

Merged
Algunenano merged 1 commit intoClickHouse:masterfrom
Algunenano:definer_missing
Aug 28, 2025
Merged

Fix missing column definer in system.tables#86295
Algunenano merged 1 commit intoClickHouse:masterfrom
Algunenano:definer_missing

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Aug 27, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix missing column definer in system.tables

If the dependency columns where not selected definer would be missing from system.tables as src_index was not updated properly in the previous step

Closes #85973
cc @pufit

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 27, 2025 •
edited
Loading

Workflow [PR], commit [2bc73cb]

Summary: ❌

job_name test_name status info comment
Stateless tests (arm_binary, parallel) failure
01825_new_type_json_ghdata_insert_select FAIL
Integration tests (amd_binary, 2/5) failure
test_storage_delta/test.py::test_concurrent_queries[False] FAIL

@Algunenano Algunenano mentioned this pull request Aug 27, 2025
Merged
1 task
@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Aug 27, 2025
@pufit pufit self-assigned this Aug 27, 2025
@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented Aug 28, 2025

@Algunenano Algunenano enabled auto-merge August 28, 2025 08:31
@Algunenano Algunenano added this pull request to the merge queue Aug 28, 2025
Merged via the queue into ClickHouse:master with commit b694c7c Aug 28, 2025
120 of 122 checks passed
@Algunenano Algunenano deleted the definer_missing branch August 28, 2025 08:48
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 28, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Aug 28, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Aug 28, 2025
Merged
robot-ch-test-poll4 added a commit that referenced this pull request Aug 28, 2025
@robot-ch-test-poll4
Merge pull request #86327 from ClickHouse/cherrypick/25.8/86295
514ab0b 
Cherry pick #86295 to 25.8: Fix missing column definer in system.tables
robot-clickhouse added a commit that referenced this pull request Aug 28, 2025
@robot-clickhouse
Backport #86295 to 25.8: Fix missing column definer in system.tables
4bd7538
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Aug 28, 2025
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 28, 2025
Algunenano added a commit that referenced this pull request Aug 28, 2025
@Algunenano
Merge pull request #86328 from ClickHouse/backport/25.8/86295
2b77f90 
Backport #86295 to 25.8: Fix missing column definer in system.tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pufit pufit pufit approved these changes

Assignees

@pufit pufit

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.8-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

01086_odbc_roundtrip is really flaky

4 participants

@Algunenano @pufit @robot-ch-test-poll1 @robot-ch-test-poll4