Skip to content

Analyzer: check for valid correlated subqueries in the FROM clause#85966

Merged
novikd merged 6 commits intomasterfrom
analyzer-forbid-correlated-join
Sep 16, 2025
Merged

Analyzer: check for valid correlated subqueries in the FROM clause#85966
novikd merged 6 commits intomasterfrom
analyzer-forbid-correlated-join

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Aug 21, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Add a check to allow correlated subqueries in the FROM clause only if they use columns from the outer query. Fixes #85469. Fixes #85402.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 21, 2025

Workflow [PR], commit [8c75168]

Summary:

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 21, 2025
@vdimir vdimir self-assigned this Aug 21, 2025
@novikd novikd added this pull request to the merge queue Sep 16, 2025
Merged via the queue into master with commit 43051f7 Sep 16, 2025
123 checks passed
@novikd novikd deleted the analyzer-forbid-correlated-join branch September 16, 2025 09:20
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 16, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Sep 16, 2025
Cherry pick #85966 to 25.6: Analyzer: check for valid correlated subqueries in the FROM clause
robot-clickhouse added a commit that referenced this pull request Sep 16, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Sep 16, 2025
Cherry pick #85966 to 25.7: Analyzer: check for valid correlated subqueries in the FROM clause
robot-clickhouse added a commit that referenced this pull request Sep 16, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Sep 16, 2025
Cherry pick #85966 to 25.8: Analyzer: check for valid correlated subqueries in the FROM clause
robot-clickhouse added a commit that referenced this pull request Sep 16, 2025
clickhouse-gh bot added a commit that referenced this pull request Sep 16, 2025
Backport #85966 to 25.6: Analyzer: check for valid correlated subqueries in the FROM clause
clickhouse-gh bot added a commit that referenced this pull request Sep 16, 2025
Backport #85966 to 25.7: Analyzer: check for valid correlated subqueries in the FROM clause
clickhouse-gh bot added a commit that referenced this pull request Sep 16, 2025
Backport #85966 to 25.8: Analyzer: check for valid correlated subqueries in the FROM clause
@robot-ch-test-poll robot-ch-test-poll added pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Column identifier __table1.a is already registered. (LOGICAL_ERROR) Logical Error: Column identifier __table1.a is already registered

4 participants