Skip to content

Fix logical error on creating table as s3Cluster() in Replicated database#85904

Merged
thevar1able merged 4 commits intomasterfrom
fix-calling-s3Cluster-from-ddl
Aug 20, 2025
Merged

Fix logical error on creating table as s3Cluster() in Replicated database#85904
thevar1able merged 4 commits intomasterfrom
fix-calling-s3Cluster-from-ddl

Conversation

@thevar1able
Copy link
Copy Markdown
Member

@thevar1able thevar1able commented Aug 19, 2025 •
edited
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix logical error on attempt to CREATE ... AS (SELECT * FROM s3Cluster(...)) with DatabaseReplicated.

Closes #85861

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 19, 2025 •
edited
Loading

Workflow [PR], commit [37d89f0]

Summary: ❌

job_name test_name status info comment
Finish Workflow failure
python3 ./ci/jobs/scripts/workflow_hooks/new_tests_check.py failure

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Aug 19, 2025
@thevar1able thevar1able changed the title Check for presence of cluster read task callback Fix logical error on creating table as s3Cluster() in Replicated database Aug 19, 2025
@thevar1able thevar1able mentioned this pull request Aug 19, 2025
Merged
@pamarcos pamarcos self-requested a review August 20, 2025 10:08
@pamarcos pamarcos self-assigned this Aug 20, 2025
pamarcos
pamarcos reviewed Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pamarcos pamarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but I'm missing a test to verify this works as expected

@thevar1able
Copy link
Copy Markdown
Member Author

thevar1able commented Aug 20, 2025 •
edited
Loading

I'm missing a test to verify this works as expected

This is a fix for a failing test on master, #85861, which was added in #85734.

@thevar1able thevar1able enabled auto-merge August 20, 2025 14:17
@thevar1able thevar1able added this pull request to the merge queue Aug 20, 2025
Merged via the queue into master with commit c401d3a Aug 20, 2025
235 of 240 checks passed
@thevar1able thevar1able deleted the fix-calling-s3Cluster-from-ddl branch August 20, 2025 15:07
This was referenced Aug 20, 2025
Closed
Merged
Merged
Merged
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 20, 2025
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Aug 20, 2025
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Aug 20, 2025
@KochetovNicolai KochetovNicolai mentioned this pull request Aug 21, 2025
Merged
1 task
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #85945 from ClickHouse/cherrypick/25.3/85904
6f3b9af 
Cherry pick #85904 to 25.3: Fix logical error on creating table as `s3Cluster()` in Replicated database
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #85946 from ClickHouse/cherrypick/25.5/85904
901f326 
Cherry pick #85904 to 25.5: Fix logical error on creating table as `s3Cluster()` in Replicated database
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #85947 from ClickHouse/cherrypick/25.6/85904
3f6f6bb 
Cherry pick #85904 to 25.6: Fix logical error on creating table as `s3Cluster()` in Replicated database
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #85948 from ClickHouse/cherrypick/25.7/85904
a85f3c0 
Cherry pick #85904 to 25.7: Fix logical error on creating table as `s3Cluster()` in Replicated database
robot-clickhouse added a commit that referenced this pull request Aug 27, 2025
@robot-clickhouse
Backport #85904 to 25.3: Fix logical error on creating table as `s3Cl…
78230b3 
…uster()` in Replicated database
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Aug 27, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Aug 27, 2025
@robot-clickhouse
Backport #85904 to 25.5: Fix logical error on creating table as `s3Cl…
6037908 
…uster()` in Replicated database
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Aug 27, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Aug 27, 2025
@robot-clickhouse
Backport #85904 to 25.6: Fix logical error on creating table as `s3Cl…
47b1d95 
…uster()` in Replicated database
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Aug 27, 2025
Merged
robot-clickhouse added a commit that referenced this pull request Aug 27, 2025
@robot-clickhouse
Backport #85904 to 25.7: Fix logical error on creating table as `s3Cl…
aac56a0 
…uster()` in Replicated database
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Aug 27, 2025
Merged
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 27, 2025
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #86263 from ClickHouse/backport/25.3/85904
1ef6256 
Backport #85904 to 25.3: Fix logical error on creating table as `s3Cluster()` in Replicated database
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #86264 from ClickHouse/backport/25.5/85904
b1ef36b 
Backport #85904 to 25.5: Fix logical error on creating table as `s3Cluster()` in Replicated database
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #86265 from ClickHouse/backport/25.6/85904
b94c7c6 
Backport #85904 to 25.6: Fix logical error on creating table as `s3Cluster()` in Replicated database
thevar1able added a commit that referenced this pull request Aug 27, 2025
@thevar1able
Merge pull request #86266 from ClickHouse/backport/25.7/85904
1f1a7ba 
Backport #85904 to 25.7: Fix logical error on creating table as `s3Cluster()` in Replicated database
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamarcos pamarcos pamarcos approved these changes

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: Next task callback is not set for query

6 participants

@thevar1able @pamarcos @KochetovNicolai @robot-clickhouse @robot-ch-test-poll @robot-ch-test-poll2