Skip to content

Fix iceberg reading by field ids for struct types#84821

Merged
scanhex12 merged 16 commits intoClickHouse:masterfrom
scanhex12:fix_complex_field_ids
Aug 4, 2025
Merged

Fix iceberg reading by field ids for struct types#84821
scanhex12 merged 16 commits intoClickHouse:masterfrom
scanhex12:fix_complex_field_ids

Conversation

@scanhex12
Copy link
Copy Markdown
Member

@scanhex12 scanhex12 commented Jul 31, 2025 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix iceberg reading by field ids for complex types

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@scanhex12 scanhex12 force-pushed the fix_complex_field_ids branch from e374308 to 92ae07f Compare July 31, 2025 17:15
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 31, 2025 •
edited
Loading

Workflow [PR], commit [e04f675]

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Jul 31, 2025
@scanhex12 scanhex12 changed the title Fix iceberg reading by field ids for complex types Fix iceberg reading by field ids for struct types Aug 1, 2025
@divanik divanik self-assigned this Aug 1, 2025
divanik
divanik reviewed Aug 1, 2025
View reviewed changes
@scanhex12 scanhex12 requested a review from divanik August 1, 2025 16:57
divanik
divanik reviewed Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@divanik divanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all the review comments are closed properly

@scanhex12 scanhex12 requested a review from divanik August 1, 2025 17:27
@scanhex12 scanhex12 enabled auto-merge August 1, 2025 17:47
@scanhex12 scanhex12 added this pull request to the merge queue Aug 4, 2025
Merged via the queue into ClickHouse:master with commit 733c912 Aug 4, 2025
31 of 35 checks passed
@scanhex12 scanhex12 deleted the fix_complex_field_ids branch August 4, 2025 20:41
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 4, 2025
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request Aug 4, 2025
Closed
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 7, 2025
@liuneng1994
Support new native parquet reader (#516)
c39ed01 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 7, 2025
Fix build due to ClickHouse/ClickHouse#84821
11a8c8e
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 8, 2025
@liuneng1994
Support new native parquet reader (#516)
4507c94 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 8, 2025
Fix build due to ClickHouse/ClickHouse#84821
3c190b6
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 11, 2025
@liuneng1994
Support new native parquet reader (#516)
2e4485d 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 11, 2025
Fix build due to ClickHouse/ClickHouse#84821
6d5e8ae
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 12, 2025
@liuneng1994
Support new native parquet reader (#516)
2f2704d 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 12, 2025
Fix build due to ClickHouse/ClickHouse#84821
7df5590
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 13, 2025
@liuneng1994
Support new native parquet reader (#516)
55bf52d 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 13, 2025
Fix build due to ClickHouse/ClickHouse#84821
ed37bbf
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 14, 2025
@liuneng1994
Support new native parquet reader (#516)
b411867 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 14, 2025
Fix build due to ClickHouse/ClickHouse#84821
43bcbe8
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 15, 2025
@liuneng1994
Support new native parquet reader (#516)
c5150b5 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 15, 2025
Fix build due to ClickHouse/ClickHouse#84821
cd3d0b4
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 16, 2025
@liuneng1994
Support new native parquet reader (#516)
93a944c 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 16, 2025
Fix build due to ClickHouse/ClickHouse#84821
eec558c
baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Aug 18, 2025
@liuneng1994
Support new native parquet reader (#516)
6db8c8a 
Fix rebase issue:
- 20250806 ClickHouse#84821
- 20250804 ClickHouse#83997
- 20250728 ClickHouse#84180
- 20250713 ClickHouse#82949
- 20250703 ClickHouse#82934
- 20250626 ClickHouse#80931
- 20250604 ClickHouse#79649
- 20250502 ClickHouse#79180
- 20250416 ClickHouse#78485
- 20250306 ClickHouse#76662

Co-authored-by: liuneng1994 <neng.liu@kyligence.com>
baibaichen pushed a commit to Kyligence/gluten that referenced this pull request Aug 18, 2025
Fix build due to ClickHouse/ClickHouse#84821
1a1de15
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 20, 2025
@divanik
Copy link
Copy Markdown
Member

divanik commented Aug 20, 2025

The test was deleted in 6c9568b. The fix should have been delivered asap, so there was a reason for doing this
My bad also that I approved this PR before some major changes, won't do it in the future.
Will create an issue that this test should be returned and fixed

@robot-ch-test-poll1 robot-ch-test-poll1 removed the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 20, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 2, 2025
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divanik divanik divanik approved these changes

Assignees

@divanik divanik

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@scanhex12 @divanik @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-ch-test-poll4 @robot-clickhouse-ci-2