Skip to content

S3Queue ordered mode fix: quit earlier if shutdown#84463

Merged
kssenii merged 2 commits intomasterfrom
s3queue-finish-earlier-if-shutdown
Jul 28, 2025
Merged

S3Queue ordered mode fix: quit earlier if shutdown#84463
kssenii merged 2 commits intomasterfrom
s3queue-finish-earlier-if-shutdown

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jul 25, 2025

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

S3Queue ordered mode fix: quit earlier if shutdown was called.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 25, 2025 •
edited
Loading

Workflow [PR], commit [8b4b731]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_asan, distributed plan, sequential) failure
00002_log_and_exception_messages_formatting FAIL
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
03552_filesystem_read_prefetches_log FAIL
Integration tests (tsan, 2/6) failure
test_storage_kafka/test_batch_slow_4.py::test_kafka_consumer_failover[generate_new_create_table_query] FAIL
Stress test (amd_msan) failure
Test script failed FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Cannot start clickhouse-server FAIL
Server failed to start (see application_errors.txt and clickhouse-server.clean.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Jul 25, 2025
@antonio2368 antonio2368 self-assigned this Jul 25, 2025
@kssenii kssenii added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jul 28, 2025
@kssenii kssenii added this pull request to the merge queue Jul 28, 2025
Merged via the queue into master with commit 5fab809 Jul 28, 2025
121 of 125 checks passed
@kssenii kssenii deleted the s3queue-finish-earlier-if-shutdown branch July 28, 2025 13:43
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 28, 2025
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 28, 2025
This was referenced Jul 28, 2025
Closed
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jul 28, 2025
@robot-ch-test-poll3
Merge pull request #84592 from ClickHouse/cherrypick/25.3/84463
69ab4f5 
Cherry pick #84463 to 25.3: S3Queue ordered mode fix: quit earlier if shutdown
robot-clickhouse added a commit that referenced this pull request Jul 28, 2025
@robot-clickhouse
Backport #84463 to 25.3: S3Queue ordered mode fix: quit earlier if sh…
4cf7272 
…utdown
This was referenced Jul 28, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jul 28, 2025
@robot-ch-test-poll3
Merge pull request #84594 from ClickHouse/cherrypick/25.5/84463
2220ae5 
Cherry pick #84463 to 25.5: S3Queue ordered mode fix: quit earlier if shutdown
robot-clickhouse added a commit that referenced this pull request Jul 28, 2025
@robot-clickhouse
Backport #84463 to 25.5: S3Queue ordered mode fix: quit earlier if sh…
5ab1587 
…utdown
This was referenced Jul 28, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jul 28, 2025
@robot-ch-test-poll3
Merge pull request #84596 from ClickHouse/cherrypick/25.6/84463
7886600 
Cherry pick #84463 to 25.6: S3Queue ordered mode fix: quit earlier if shutdown
robot-clickhouse added a commit that referenced this pull request Jul 28, 2025
@robot-clickhouse
Backport #84463 to 25.6: S3Queue ordered mode fix: quit earlier if sh…
7a5cf10 
…utdown
This was referenced Jul 28, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Jul 28, 2025
@robot-ch-test-poll3
Merge pull request #84598 from ClickHouse/cherrypick/25.7/84463
77b571f 
Cherry pick #84463 to 25.7: S3Queue ordered mode fix: quit earlier if shutdown
robot-clickhouse added a commit that referenced this pull request Jul 28, 2025
@robot-clickhouse
Backport #84463 to 25.7: S3Queue ordered mode fix: quit earlier if sh…
12b37c7 
…utdown
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Jul 28, 2025
Merged
@arthurpassos arthurpassos mentioned this pull request Jul 28, 2025
Merged
1 task
clickhouse-gh bot added a commit that referenced this pull request Jul 28, 2025
@clickhouse-gh
Merge pull request #84599 from ClickHouse/backport/25.7/84463
bd1220b 
Backport #84463 to 25.7: S3Queue ordered mode fix: quit earlier if shutdown
clickhouse-gh bot added a commit that referenced this pull request Jul 28, 2025
@clickhouse-gh
Merge pull request #84597 from ClickHouse/backport/25.6/84463
3ec452a 
Backport #84463 to 25.6: S3Queue ordered mode fix: quit earlier if shutdown
kssenii added a commit that referenced this pull request Jul 28, 2025
@kssenii
Merge pull request #84595 from ClickHouse/backport/25.5/84463
0f627bd 
Backport #84463 to 25.5: S3Queue ordered mode fix: quit earlier if shutdown
kssenii added a commit that referenced this pull request Jul 28, 2025
@kssenii
Merge pull request #84593 from ClickHouse/backport/25.3/84463
2bb87fe 
Backport #84463 to 25.3: S3Queue ordered mode fix: quit earlier if shutdown
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kssenii @antonio2368 @robot-ch-test-poll1 @robot-ch-test-poll3 @robot-clickhouse-ci-1