Merged
Conversation
Contributor
|
Workflow [PR], commit [93542ee] Summary: ❌
|
azat
approved these changes
Jul 17, 2025
Member
|
@antonio2368 can you also apply the following so that the test can be run w/o diff --git a/tests/queries/0_stateless/02233_HTTP_ranged.python b/tests/queries/0_stateless/02233_HTTP_ranged.python
index c4a584ae7ae..da20304d485 100644
--- a/tests/queries/0_stateless/02233_HTTP_ranged.python
+++ b/tests/queries/0_stateless/02233_HTTP_ranged.python
@@ -55,9 +55,12 @@ EXPECTED_ANSWER = """{\\n\\t"login": "ClickHouse",\\n\\t"id": 54801242,\\n\\t"na
#####################################################################################
# IP-address of this host accessible from the outside world. Get the first one
-HTTP_SERVER_HOST = (
- subprocess.check_output(["hostname", "-i"]).decode("utf-8").strip().split()[0]
-)
+try:
+ HTTP_SERVER_HOST = (
+ subprocess.check_output(["hostname", "-i"]).decode("utf-8").strip().split()[0]
+ )
+except:
+ HTTP_SERVER_HOST = "127.0.0.1"
IS_IPV6 = is_ipv6(HTTP_SERVER_HOST)
HTTP_SERVER_PORT = get_local_port(HTTP_SERVER_HOST, IS_IPV6)
@@ -233,7 +236,7 @@ def start_server(): |
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Jul 17, 2025
Cherry pick #83891 to 25.7: Fix 02233_HTTP_ranged
robot-clickhouse
added a commit
that referenced
this pull request
Jul 17, 2025
antonio2368
added a commit
that referenced
this pull request
Jul 18, 2025
Backport #83891 to 25.7: Fix 02233_HTTP_ranged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fix #82844
After #82949, we decide if parallel download can be used based on active readers (
max_threads).For single URL we set num_streams to 1 but with parallel replicas we don't know how many tasks there are so we keep
max_threads.Documentation entry for user-facing changes