Skip to content

hold the temporary part lock when executeReplaceRange#83095

Merged
CheSema merged 1 commit intomasterfrom
chesema-replace-partition-fix
Jul 3, 2025
Merged

hold the temporary part lock when executeReplaceRange#83095
CheSema merged 1 commit intomasterfrom
chesema-replace-partition-fix

Conversation

@CheSema
Copy link
Copy Markdown
Member

@CheSema CheSema commented Jul 2, 2025

Related to #76625
There I found that Clickhouse tries to commit part with no files inside

Here the logs:
https://pastila.nl/?00128b02/b621f10f12d90998ca425c6df6940ad7#FB0w9c83TiG7T3UPZm+MYg==

In short: cleanup thread dropped the part which is being committing

Removing temporary directory /home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/ci/tmp/run_r0/disks/s3/store/b76/b762e830-22a2-4a2d-875e-d55a3090f21a/tmp_replace_from_fetch_8_6_6_0/

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@CheSema CheSema changed the title hold the temporary part lock hold the temporary part lock when executeReplaceRange Jul 2, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jul 2, 2025 •
edited
Loading

Workflow [PR], commit [3ec7404]

Summary: ❌

job_name test_name status info comment
Build (fuzzers) error
Stateless tests (arm_binary) failure
02922_server_exit_code FAIL
Integration tests (tsan, 1/6) failure
test_database_delta/test.py::test_embedded_database_and_tables[0] FAIL
test_database_delta/test.py::test_multiple_schemes_tables FAIL
test_database_delta/test.py::test_embedded_database_and_tables[1] FAIL
test_database_delta/test.py::test_timestamp_ntz[0] FAIL
test_database_delta/test.py::test_timestamp_ntz[1] FAIL

@clickhouse-gh clickhouse-gh bot added the pr-ci label Jul 2, 2025
@CheSema CheSema mentioned this pull request Jul 2, 2025
Merged
1 task
@Michicosun Michicosun self-assigned this Jul 2, 2025
@CheSema
Copy link
Copy Markdown
Member Author

CheSema commented Jul 3, 2025

Stateless tests (arm_binary)
02922_server_exit_code
#82106

Integration tests (tsan, 1/6)
test_database_delta
#79109

Michicosun
Michicosun approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Michicosun Michicosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CheSema CheSema added this pull request to the merge queue Jul 3, 2025
Merged via the queue into master with commit 84a90e8 Jul 3, 2025
231 of 240 checks passed
@CheSema CheSema deleted the chesema-replace-partition-fix branch July 3, 2025 11:10
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 3, 2025
@CheSema CheSema added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jul 15, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-backports-created-cloud deprecated label, NOOP pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jul 15, 2025
This was referenced Jul 15, 2025
Closed
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse-ci-1
Merge pull request #83808 from ClickHouse/cherrypick/25.3/83095
170a37f 
Cherry pick #83095 to 25.3: hold the temporary part lock when executeReplaceRange
robot-clickhouse added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse
Backport #83095 to 25.3: hold the temporary part lock when executeRep…
4c9828c 
…laceRange
This was referenced Jul 15, 2025
Merged
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse-ci-1
Merge pull request #83810 from ClickHouse/cherrypick/25.4/83095
756d5f0 
Cherry pick #83095 to 25.4: hold the temporary part lock when executeReplaceRange
robot-clickhouse added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse
Backport #83095 to 25.4: hold the temporary part lock when executeRep…
2d9d531 
…laceRange
This was referenced Jul 15, 2025
Merged
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse-ci-1
Merge pull request #83812 from ClickHouse/cherrypick/25.5/83095
a790df5 
Cherry pick #83095 to 25.5: hold the temporary part lock when executeReplaceRange
robot-clickhouse added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse
Backport #83095 to 25.5: hold the temporary part lock when executeRep…
86bc262 
…laceRange
This was referenced Jul 15, 2025
Merged
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse-ci-1
Merge pull request #83814 from ClickHouse/cherrypick/25.6/83095
34dc894 
Cherry pick #83095 to 25.6: hold the temporary part lock when executeReplaceRange
robot-clickhouse added a commit that referenced this pull request Jul 15, 2025
@robot-clickhouse
Backport #83095 to 25.6: hold the temporary part lock when executeRep…
9cf0db2 
…laceRange
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jul 15, 2025
Merged
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 15, 2025
clickhouse-gh bot added a commit that referenced this pull request Jul 16, 2025
@clickhouse-gh
Merge pull request #83815 from ClickHouse/backport/25.6/83095
32159b1 
Backport #83095 to 25.6: hold the temporary part lock when executeReplaceRange
CheSema added a commit that referenced this pull request Jul 16, 2025
@CheSema
Merge pull request #83813 from ClickHouse/backport/25.5/83095
dceb2d4 
Backport #83095 to 25.5: hold the temporary part lock when executeReplaceRange
CheSema added a commit that referenced this pull request Jul 16, 2025
@CheSema
Merge pull request #83811 from ClickHouse/backport/25.4/83095
dfdc1a0 
Backport #83095 to 25.4: hold the temporary part lock when executeReplaceRange
CheSema added a commit that referenced this pull request Jul 16, 2025
@CheSema
Merge pull request #83809 from ClickHouse/backport/25.3/83095
36dff6d 
Backport #83095 to 25.3: hold the temporary part lock when executeReplaceRange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Michicosun Michicosun Michicosun approved these changes

Assignees

@Michicosun Michicosun

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-ci pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CheSema @Michicosun @robot-ch-test-poll @robot-clickhouse-ci-2