Skip to content

Remove parasitic CSE from formatter#82838

Merged
alexey-milovidov merged 54 commits intomasterfrom
no-parasitic-cse-in-formatter
Jan 23, 2026
Merged

Remove parasitic CSE from formatter#82838
alexey-milovidov merged 54 commits intomasterfrom
no-parasitic-cse-in-formatter

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jun 29, 2025

Changelog category (leave one):

  • Backward Incompatible Change

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix inconsistent formatting caused by an incorrect substitution of aliases in the formatter. This closes #82833. This closes #82832. This closes #68296. This change is potentially backward incompatible: when the analyzer is disabled, certain CREATE VIEW queries with IN referencing an alias cannot be processed. To prevent the incompatibility, enable the analyzer (it is enabled by default since 24.3).

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 29, 2025

Workflow [PR], commit [fa05d5b]

Summary:

job_name test_name status info comment
Stateless tests (amd_tsan, parallel, 1/2) failure
00625_arrays_in_nested FAIL cidb
Stateless tests (amd_msan, parallel, 1/2) failure
03300_merge_parts_metric FAIL cidb
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue

@clickhouse-gh clickhouse-gh bot added the pr-improvement Pull request with some product improvements label Jun 29, 2025
@PedroTadim PedroTadim self-requested a review July 4, 2025 11:25
@PedroTadim
Copy link
Copy Markdown
Member

LGTM

@PedroTadim PedroTadim enabled auto-merge July 4, 2025 11:52
@clickhouse-gh clickhouse-gh bot added pr-backward-incompatible Pull request with backwards incompatible changes and removed pr-improvement Pull request with some product improvements labels Jul 28, 2025
@alexey-milovidov alexey-milovidov force-pushed the no-parasitic-cse-in-formatter branch from 18ad334 to fcf9f02 Compare July 28, 2025 06:46
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 9, 2025

Dear @PedroTadim, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@george-larionov george-larionov self-assigned this Jan 12, 2026
@alexey-milovidov alexey-milovidov merged commit 5d9a6fb into master Jan 23, 2026
128 of 134 checks passed
@alexey-milovidov alexey-milovidov deleted the no-parasitic-cse-in-formatter branch January 23, 2026 22:04
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backward-incompatible Pull request with backwards incompatible changes pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

4 participants