removing no longer needed logic around rhs arg parens for IN

george-larionov · george-larionov · commit 47bf7286ea84 · 2026-01-21T18:57:19.000Z
diff --git a/src/Parsers/ASTFunction.cpp b/src/Parsers/ASTFunction.cpp
@@ -446,33 +446,7 @@ void ASTFunction::formatImplWithoutAlias(WriteBuffer & ostr, const FormatSetting
                 arguments->children[0]->format(ostr, settings, state, nested_need_parens);
                 ostr << it->operator_name;
 
-                /// Format x IN 1 as x IN (1): put parens around rhs even if there is a single element in set.
-                const auto * second_arg_func = arguments->children[1]->as<ASTFunction>();
-                const auto * second_arg_literal = arguments->children[1]->as<ASTLiteral>();
-                bool is_literal_tuple_or_array = second_arg_literal
-                    && (second_arg_literal->value.getType() == Field::Types::Tuple
-                        || second_arg_literal->value.getType() == Field::Types::Array);
-
-                /** Conditions for extra parens:
-                 *  1. Is IN operator
-                 *  2. 2nd arg is not subquery, function, or literal tuple or array
-                 *  3. If the 2nd argument has alias, we ignore condition 2 and add extra parens
-                 *
-                 *  Condition 3 is needed to avoid inconsistency in format-parse-format debug check in executeQuery.cpp
-                 */
-                bool extra_parents_around_in_rhs = is_in_operator
-                    && ((!arguments->children[1]->as<ASTSubquery>() && !second_arg_func && !is_literal_tuple_or_array)
-                        || !arguments->children[1]->tryGetAlias().empty());
-
-                if (extra_parents_around_in_rhs)
-                {
-                    ostr << '(';
-                    arguments->children[1]->format(ostr, settings, state, nested_dont_need_parens);
-                    ostr << ')';
-                }
-
-                if (!extra_parents_around_in_rhs)
-                    arguments->children[1]->format(ostr, settings, state, nested_need_parens);
+                arguments->children[1]->format(ostr, settings, state, nested_need_parens);
 
                 if (need_parens_around_in)
                     ostr << ')';
diff --git a/tests/queries/0_stateless/03359_analyzer_rewrite_view_query.sql b/tests/queries/0_stateless/03359_analyzer_rewrite_view_query.sql
@@ -1,5 +1,3 @@
-set enable_analyzer=1;
-
 CREATE TABLE mydestination
 (
     `object` String

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-set enable_analyzer=1;`
`2`		`-`
`3`	`1`	`CREATE TABLE mydestination`
`4`	`2`	`(`
`5`	`3`	`object` String