Fix inconsistent formatting of table functions that have the same name as operators#82825
Merged
alexey-milovidov merged 48 commits intomasterfrom Oct 12, 2025
Merged
Conversation
Contributor
|
Workflow [PR], commit [f2bb9eb] Summary: ❌
|
PedroTadim
reviewed
Jul 4, 2025
tests/queries/0_stateless/03552_inconsistent_formatting_operator_as_table_function.sql
Show resolved
Hide resolved
…b.com:ClickHouse/ClickHouse into fix-inconsistent-formatting-of-some-operators
Member
Author
|
It's totally ok if EXPLAIN SYNTAX does not format operators. Actually it is even closer to the meaning of the word "syntax". |
Member
|
I still want to make it more consistent in a way that if AST was parsed as operator, we can keep an operator in formatted query. |
Member
|
That's quite radical. |
Member
|
let's remove KQL tests for now - I'll add |
Contributor
|
Dear @KochetovNicolai, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
Member
Author
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
In previous versions, queries with table functions named the same way as the implementation functions for operators were formatted inconsistently. Closes #81601. Closes #81977. Closes #82834. Closes #82835. EXPLAIN SYNTAX queries will not format operators - the new behavior better reflects the purpose of explaining syntax.
clickhouse-format,formatQuery, and similar will not format functions as operators if the query contained them in a functional form.