Skip to content

Fix S3 table function argument validation in secret masking#82056

Merged
vdimir merged 1 commit intomasterfrom
vdimir/issue_80620_fix2
Jun 18, 2025
Merged

Fix S3 table function argument validation in secret masking#82056
vdimir merged 1 commit intomasterfrom
vdimir/issue_80620_fix2

Conversation

@vdimir
Copy link
Copy Markdown
Member

@vdimir vdimir commented Jun 17, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 17, 2025 •
edited
Loading

Workflow [PR], commit [222fdec]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_tsan, 3/3) failure
02160_client_autocomplete_parse_query FAIL
Stateless tests (amd_ubsan) failure
01278_min_insert_block_size_rows_for_materialized_views FAIL
Stress test (amd_tsan) failure
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jun 17, 2025
@evillique evillique self-assigned this Jun 17, 2025
@vdimir vdimir added this pull request to the merge queue Jun 18, 2025
Merged via the queue into master with commit afe83c1 Jun 18, 2025
116 of 124 checks passed
@vdimir vdimir deleted the vdimir/issue_80620_fix2 branch June 18, 2025 09:04
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 18, 2025
@Algunenano
Copy link
Copy Markdown
Member

Algunenano commented Jun 23, 2025

Adding it to 25.6

@Algunenano Algunenano self-assigned this Jun 23, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jun 23, 2025
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Jun 23, 2025
@robot-ch-test-poll1
Merge pull request #82394 from ClickHouse/cherrypick/25.6/82056
a665502 
Cherry pick #82056 to 25.6: Fix S3 table function argument validation in secret masking
robot-clickhouse added a commit that referenced this pull request Jun 23, 2025
@robot-clickhouse
Backport #82056 to 25.6: Fix S3 table function argument validation in…
16beec0 
… secret masking
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jun 23, 2025
Merged
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label Jun 23, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 23, 2025
vdimir added a commit that referenced this pull request Jun 23, 2025
@vdimir
Merge pull request #82395 from ClickHouse/backport/25.6/82056
4760995 
Backport #82056 to 25.6: Fix S3 table function argument validation in secret masking
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@Algunenano Algunenano

@evillique evillique

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.6-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: 'Bad cast from type DB::IdentifierNode to DB::ColumnNode'

6 participants

@vdimir @Algunenano @evillique @robot-clickhouse @robot-ch-test-poll3 @svb-alt