Skip to content

Disable async logger due to possible deadlock on shutdown#82034

Closed
azat wants to merge 1 commit intoClickHouse:masterfrom
azat:disable-async-logger
Closed

Disable async logger due to possible deadlock on shutdown#82034
azat wants to merge 1 commit intoClickHouse:masterfrom
azat:disable-async-logger

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jun 17, 2025 •
edited
Loading

Refs: https://pastila.nl/?0024bdfc/d647932af97f68f225dffef20154f102#aF2+D7zvdKZfYBT3/baJ2w==

Otherwise it breaks some tests, i.e. #81916

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Introduced in: #80125

@azat azat requested a review from Algunenano June 17, 2025 13:31
@azat azat changed the title Disable async logger temporary (due to possible deadlock) Disable async logger due to possible deadlock Jun 17, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 17, 2025 •
edited
Loading

Workflow [PR], commit [7a4b56f]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary) failure
00002_log_and_exception_messages_formatting FAIL
Found signal in gdb.log FAIL
Stateless tests (amd_binary, ParallelReplicas, s3 storage) failure
03403_read_in_order_streams_memory_usage FAIL
Integration tests (asan, old analyzer, 1/6) failure
test_shutdown_static_destructor_failure/test.py::test_shutdown FAIL
Integration tests (tsan, 3/6) failure
test_create_user_and_login/test.py::test_login_as_dropped_user_xml FAIL

@azat azat mentioned this pull request Jun 17, 2025
Merged
@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 17, 2025
@azat azat added 🍃 green ci 🌿 Fixing flaky tests in CI v25.6-must-backport labels Jun 17, 2025
@azat azat mentioned this pull request Jun 17, 2025
Merged
@azat azat changed the title Disable async logger due to possible deadlock Disable async logger due to possible deadlock on shutdown Jun 17, 2025
@SmitaRKulkarni SmitaRKulkarni self-assigned this Jun 17, 2025
@azat azat enabled auto-merge June 17, 2025 14:43
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 17, 2025

(@Algunenano approved in DM:))

@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 17, 2025 •
edited
Loading

PR / Integration tests (tsan, 3/6) (pull_request)Failing after 88m

Stateless tests (amd_binary, ParallelReplicas, s3 storage) — Failed: 1, Passed: 7054, Skipped: 885

  • 03403_read_in_order_streams_memory_usage flaky

Integration tests (asan, old analyzer, 1/6) — fail: 1, passed: 590

Stateless tests (amd_binary) — Failed: 1, Passed: 8069, Skipped: 10

@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 17, 2025 •
edited
Loading

Actually synchronous logging now triggers - #82059

So I hate to do this, but I will have to revert the whole PR

@azat azat mentioned this pull request Jun 17, 2025
Merged
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 17, 2025 •
edited
Loading

Closed in favor of #82068

@azat azat closed this Jun 17, 2025
auto-merge was automatically disabled June 17, 2025 20:08

Pull request was closed

@azat azat deleted the disable-async-logger branch June 18, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmitaRKulkarni SmitaRKulkarni SmitaRKulkarni approved these changes

@Algunenano Algunenano Awaiting requested review from Algunenano

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog v25.6-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@azat @SmitaRKulkarni