Skip to content

tests: improve stateless tests for clickhouse-server#81916

Merged
azat merged 4 commits intoClickHouse:masterfrom
azat:tests/01507_clickhouse_server_start_with_embedded_config
Jun 18, 2025
Merged

tests: improve stateless tests for clickhouse-server#81916
azat merged 4 commits intoClickHouse:masterfrom
azat:tests/01507_clickhouse_server_start_with_embedded_config

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jun 16, 2025

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

This test became flaky recently (first relevant failure from 3 of Jun), but it hangs during server shutdown, let's add some debugging - https://play.clickhouse.com/play?user=play#U0VMRUNUIGNoZWNrX3N0YXJ0X3RpbWUsIGNoZWNrX25hbWUsIHRlc3RfbmFtZSwgcmVwb3J0X3VybApGUk9NIGNoZWNrcwpXSEVSRSBjaGVja19zdGFydF90aW1lID49IG5vdygpIC0gSU5URVJWQUwgNDggZGF5Ci8vICAgIEFORCAoaGVhZF9yZWYgPSAnbWFzdGVyJyBBTkQgc3RhcnRzV2l0aChoZWFkX3JlcG8sICdDbGlja0hvdXNlLycpKQogICAgQU5EIHRlc3Rfc3RhdHVzICE9ICdTS0lQUEVEJwogICAgQU5EICh0ZXN0X3N0YXR1cyBMSUtFICdGJScgT1IgdGVzdF9zdGF0dXMgTElLRSAnRSUnKSAKICAgIEFORCBjaGVja19zdGF0dXMgIT0gJ3N1Y2Nlc3MnCiAgICBBTkQgcG9zaXRpb24odGVzdF9uYW1lLCAnMDE1MDdfY2xpY2tob3VzZV9zZXJ2ZXJfc3RhcnRfd2l0aF9lbWJlZGRlZF9jb25maWcnKSA+IDAKT1JERVIgQlkgY2hlY2tfc3RhcnRfdGltZQ==

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 16, 2025

Workflow [PR], commit [297848c]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 16, 2025
@SmitaRKulkarni SmitaRKulkarni self-assigned this Jun 16, 2025
@azat azat marked this pull request as draft June 16, 2025 13:24
@azat azat marked this pull request as draft June 16, 2025 13:24
@azat azat force-pushed the tests/01507_clickhouse_server_start_with_embedded_config branch from 297848c to 232367d Compare June 16, 2025 17:56
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 16, 2025 •
edited
Loading

Workflow [PR], commit [e147ace]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_tsan, 3/3) failure
02160_client_autocomplete_parse_query FAIL

@azat azat changed the title tests: dump server log on failure in 01507_clickhouse_server_start_with_embedded_config tests: improve stateless tests for clickhouse-server Jun 17, 2025
@azat azat mentioned this pull request Jun 17, 2025
Closed
@azat azat marked this pull request as ready for review June 17, 2025 13:33
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 17, 2025

Okay, so the problem was an async logger, will be disabled here -#82034

And this PR contains just some improvements and ensures that the CI will pass without async logger

I will remove the last patch once #82034 will be merged

@azat azat marked this pull request as draft June 17, 2025 13:35
@azat azat mentioned this pull request Jun 17, 2025
Merged
@azat azat force-pushed the tests/01507_clickhouse_server_start_with_embedded_config branch from 0e98052 to e147ace Compare June 18, 2025 07:16
@azat azat marked this pull request as ready for review June 18, 2025 07:16
@azat azat requested a review from SmitaRKulkarni June 18, 2025 07:16
@azat
Copy link
Copy Markdown
Member Author

azat commented Jun 18, 2025

Stateless tests (amd_tsan, 3/3) — Failed: 1, Passed: 2626, Skipped: 56

@azat azat added this pull request to the merge queue Jun 18, 2025
Merged via the queue into ClickHouse:master with commit 923beb8 Jun 18, 2025
119 of 122 checks passed
@azat azat deleted the tests/01507_clickhouse_server_start_with_embedded_config branch June 18, 2025 19:01
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmitaRKulkarni SmitaRKulkarni Awaiting requested review from SmitaRKulkarni

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azat @SmitaRKulkarni @robot-clickhouse-ci-1