Skip to content

Fix monotonicity of the cast function#81722

Merged
yariks5s merged 1 commit intoClickHouse:masterfrom
zoomxi:fix_80742
Jun 18, 2025
Merged

Fix monotonicity of the cast function#81722
yariks5s merged 1 commit intoClickHouse:masterfrom
zoomxi:fix_80742

Conversation

@zoomxi
Copy link
Copy Markdown
Contributor

@zoomxi zoomxi commented Jun 12, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

This PR might close #80742.

This PR addresses the missing handling for all scenarios involving Field::Types::UInt64 and Field::Types::Int64, which were not fully covered in the previous PR #80783 that only handled big integer cases.

@zoomxi
Copy link
Copy Markdown
Contributor Author

zoomxi commented Jun 12, 2025

cc @yariks5s

@tuanpach tuanpach added the can be tested Allows running workflows for external contributors label Jun 12, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jun 12, 2025 •
edited
Loading

Workflow [PR], commit [e72407f]

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jun 12, 2025
@yariks5s yariks5s self-assigned this Jun 12, 2025
@yariks5s
Copy link
Copy Markdown
Member

yariks5s commented Jun 12, 2025

@zoomxi should we revert #80783?

@yariks5s
Copy link
Copy Markdown
Member

yariks5s commented Jun 12, 2025 •
edited
Loading

I will revert that PR. That PR is marked as a bugfix and needs to be backported to previous versions, which doesn't make sense because it fixes nothing. We can bring all changes from that PR here and backport only once.🙂

This was referenced Jun 12, 2025
Merged
Merged
@zoomxi
Copy link
Copy Markdown
Contributor Author

zoomxi commented Jun 13, 2025

Integration tests (asan, old analyzer, 6/6)

test_postgresql_replica_database_engine/test_1.py::test_abrupt_connection_loss_while_heavy_replication is flaky.

Stress test (amd_tsan)

txn->getState() != MergeTreeTransaction::COMMITTING
It seems unrelated to this PR.

@yariks5s
Copy link
Copy Markdown
Member

yariks5s commented Jun 13, 2025

Stress test (amd_tsan) -- #80021

@zoomxi
Copy link
Copy Markdown
Contributor Author

zoomxi commented Jun 14, 2025

AST fuzzer (amd_debug) -- #81601

Integration tests (release, 1/4) -- #80424

@zoomxi zoomxi requested a review from yariks5s June 16, 2025 08:53
@zoomxi
Copy link
Copy Markdown
Contributor Author

zoomxi commented Jun 18, 2025

All checks have passed. PTAL @yariks5s

@yariks5s
Copy link
Copy Markdown
Member

yariks5s commented Jun 18, 2025

Looks good, thanks

@yariks5s yariks5s enabled auto-merge June 18, 2025 14:07
@yariks5s yariks5s added this pull request to the merge queue Jun 18, 2025
Merged via the queue into ClickHouse:master with commit 36b0164 Jun 18, 2025
237 of 238 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 18, 2025
@zoomxi zoomxi deleted the fix_80742 branch June 19, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yariks5s yariks5s Awaiting requested review from yariks5s

Assignees

@yariks5s yariks5s

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: 'check_in_range(result_exact_range, BoolMask::consider_only_can_be_false) == BoolMask(true, false)'.

4 participants

@zoomxi @yariks5s @robot-ch-test-poll4 @tuanpach