Might fix monotonicity of the cast function for big integer types.#80783
Merged
yariks5s merged 2 commits intoClickHouse:masterfrom Jun 10, 2025
Merged
Conversation
Contributor
fc8e32a to
15fe4d0
Compare
Contributor
Author
|
Performance Comparison (amd_release,master_head,3/3) Performance Comparison (amd_release,master_head,2/3)
@yariks5s Could you please take a look? Thanks |
15fe4d0 to
99378fe
Compare
Contributor
Author
|
@yariks5s I've rebased onto master, and all checks are passing. Please review this PR when you have a moment. Thanks. |
yariks5s
approved these changes
May 30, 2025
Contributor
Author
Contributor
Author
|
Can we merge this PR now? @yariks5s |
Member
|
Yep, now it's good to go, thank you. |
Merged
via the queue into
ClickHouse:master
with commit Jun 10, 2025
26aa87a
118 of 121 checks passed
This was referenced Jun 10, 2025
Member
|
Looks like this PR didn't fix it: #80742 (comment) |
Contributor
Author
The example in #80742 has been resolved and added to the function test. There might still be other corner cases, so I'll take a closer look. Thank you for the reminder. |
Member
|
Revert reason: #81722 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
This PR might close #80742.
When casting from a big integer type, getMonotonicityForRange(UInt128, field, field) appears to be monotonic if field is null. However, if field's type is UInt128, the function seems to lose monotonicity, likely because only native integer types are currently supported.
To address this, the PR adds a check in ToNumberMonotonicity to verify whether the type is a big integer when field is null, ensuring correct monotonicity behavior.