Slow down S3 client after network error#80035
Merged
vitlibar merged 3 commits intoClickHouse:masterfrom May 14, 2025
Merged
Conversation
Contributor
e2c89c4 to
b1d2743
Compare
mstetsyuk
approved these changes
May 10, 2025
…even if executed in parallel thread) fails with a retryable network error.
21fb53a to
13a8c91
Compare
Member
Author
|
CI failures are unrelated:
|
Merged
via the queue into
ClickHouse:master
with commit May 14, 2025
47a3bf1
117 of 122 checks passed
baibaichen
pushed a commit
to Kyligence/gluten
that referenced
this pull request
May 15, 2025
baibaichen
pushed a commit
to apache/gluten
that referenced
this pull request
May 15, 2025
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20250515) * Fix build due to ClickHouse/ClickHouse#80035 * Fix build due to ClickHouse/ClickHouse#80050 --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang chen <chenchang@apache.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add setting
s3_slow_all_threads_after_network_error.When set to
true(default) than all threads executing s3 requests to the same endpoint get slow down for a while after one s3 request fails with a retryable network error. This is the new default.When set to
falsethan each thread executing s3 request uses an independent set of backoffs on network errors. This is the old behavior.