Skip to content

Analyzer: Fix correlated column expression check#79727

Merged
novikd merged 8 commits intomasterfrom
analyzer-fix-alias-column-resolve
Jun 6, 2025
Merged

Analyzer: Fix correlated column expression check#79727
novikd merged 8 commits intomasterfrom
analyzer-fix-alias-column-resolve

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Apr 30, 2025 •
edited
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix logical errors about a column's unknown origin scope produced while checking if this column is correlated. Fixes #78183. Fixes #79451.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Apr 30, 2025 •
edited
Loading

Workflow [PR], commit [cdfa32f]

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Apr 30, 2025
@divanik divanik self-assigned this May 2, 2025
@novikd novikd changed the title Analyzer: Fix alias column expression resolution Analyzer: Fix correlated column expression check Jun 4, 2025
@novikd
Copy link
Copy Markdown
Member Author

novikd commented Jun 6, 2025

Performance Comparison (amd_release,master_head,2/3) — 2 faster, 7 slower, 15 unstable

Unrelated

CH Inc sync — tests failed

Unrelated

@novikd novikd added this pull request to the merge queue Jun 6, 2025
Merged via the queue into master with commit 306b770 Jun 6, 2025
345 of 353 checks passed
@novikd novikd deleted the analyzer-fix-alias-column-resolve branch June 6, 2025 14:06
This was referenced Jun 6, 2025
Closed
Closed
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Jun 6, 2025
@robot-ch-test-poll1
Merge pull request #81425 from ClickHouse/cherrypick/25.4/79727
6564408 
Cherry pick #79727 to 25.4: Analyzer: Fix correlated column expression check
robot-clickhouse added a commit that referenced this pull request Jun 6, 2025
@robot-clickhouse
Backport #79727 to 25.4: Analyzer: Fix correlated column expression c…
0955606 
…heck
This was referenced Jun 6, 2025
Merged
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Jun 6, 2025
@robot-ch-test-poll1
Merge pull request #81427 from ClickHouse/cherrypick/25.5/79727
dd4e3f1 
Cherry pick #79727 to 25.5: Analyzer: Fix correlated column expression check
robot-clickhouse added a commit that referenced this pull request Jun 6, 2025
@robot-clickhouse
Backport #79727 to 25.5: Analyzer: Fix correlated column expression c…
a8015d9 
…heck
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jun 6, 2025
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 6, 2025
@azat
Copy link
Copy Markdown
Member

azat commented Jun 6, 2025

Should this also fix

@novikd
Copy link
Copy Markdown
Member Author

novikd commented Jun 6, 2025

Yes, it is. I'll add tests

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Jun 6, 2025
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 6, 2025
alexey-milovidov added a commit that referenced this pull request Jun 6, 2025
@alexey-milovidov
Merge pull request #81428 from ClickHouse/backport/25.5/79727
ce8d65b 
Backport #79727 to 25.5: Analyzer: Fix correlated column expression check
novikd added a commit that referenced this pull request Jun 13, 2025
@novikd
Merge pull request #81426 from ClickHouse/backport/25.4/79727
ee47bdd 
Backport #79727 to 25.4: Analyzer: Fix correlated column expression check
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
ilejn pushed a commit to Altinity/ClickHouse that referenced this pull request Jul 9, 2025
@novikd @ilejn
Merge pull request ClickHouse#79727 from ClickHouse/analyzer-fix-alia…
c2f6a21 
…s-column-resolve

Analyzer: Fix correlated column expression check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divanik divanik divanik approved these changes

Assignees

@divanik divanik

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: Cannot find the original scope of the column UNSUPPORTED_METHOD error when adding alias based on JSON

7 participants

@novikd @azat @divanik @robot-clickhouse @robot-ch-test-poll2 @robot-ch-test-poll3 @robot-clickhouse-ci-2