system.query_condition_cache: Add field for plaintext condition#78671
Merged
rschu1ze merged 3 commits intoClickHouse:masterfrom Apr 11, 2025
Merged
system.query_condition_cache: Add field for plaintext condition#78671rschu1ze merged 3 commits intoClickHouse:masterfrom
system.query_condition_cache: Add field for plaintext condition#78671rschu1ze merged 3 commits intoClickHouse:masterfrom
Conversation
Contributor
2b3dda7 to
2b65a0e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
0b805b1 to
0714b7f
Compare
devcrafter
approved these changes
Apr 9, 2025
| const auto & outputs = filter_actions_dag->getOutputs(); | ||
|
|
||
| /// Restrict to the case that ActionsDAG has a single output. This isn't technically necessary but de-risks the | ||
| /// implementatino a lot while not losing much usefulness. |
Member
There was a problem hiding this comment.
Suggested change
| /// implementatino a lot while not losing much usefulness. | |
| /// implementation a lot while not losing much usefulness. |
| {"table_uuid", std::make_shared<DataTypeUUID>(), "The table UUID."}, | ||
| {"part_name", std::make_shared<DataTypeString>(), "The part name."}, | ||
| {"key_hash", std::make_shared<DataTypeUInt64>(), "The hash of the filter condition."}, | ||
| {"condition", std::make_shared<DataTypeString>(), "The hashed filter condition. Only set if setting query_condition_cache_store_conditions_as_plaintext = true."}, |
Member
There was a problem hiding this comment.
Suggested change
| {"condition", std::make_shared<DataTypeString>(), "The hashed filter condition. Only set if setting query_condition_cache_store_conditions_as_plaintext = true."}, | |
| {"condition", std::make_shared<DataTypeString>(), "The filter condition. Only set if setting query_condition_cache_store_conditions_as_plaintext = true."}, |
tests/queries/0_stateless/03229_query_condition_cache_plaintext_condition.sql
Show resolved
Hide resolved
Member
Author
|
@devcrafter Thanks. Will incorporate your comments as part of #77983 |
Merged
via the queue into
ClickHouse:master
with commit Apr 11, 2025
e516076
116 of 121 checks passed
This was referenced Apr 16, 2025
Closed
Closed
Closed
Closed
robot-ch-test-poll
added a commit
that referenced
this pull request
Apr 17, 2025
Cherry pick #78671 to 25.4: `system.query_condition_cache`: Add field for plaintext condition
robot-clickhouse
added a commit
that referenced
this pull request
Apr 17, 2025
…r plaintext condition
alexey-milovidov
added a commit
that referenced
this pull request
Apr 17, 2025
Backport #78671 to 25.4: `system.query_condition_cache`: Add field for plaintext condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was hard to understand for some queries which filter conditions a hash in the query condition cache represented. Now storing the original filter condition explicitly.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added field
conditionto system tablesystem.query_condition_cache. It stores the plaintext condition whose hash is used as a key in the query condition cache.