Skip to content

Make the move operator for ColumnDefault truly noexcept#77670

Merged
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom
vitlibar:make-column-default-move-operator-truly-noexcept
Mar 17, 2025
Merged

Make the move operator for ColumnDefault truly noexcept#77670
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom
vitlibar:make-column-default-move-operator-truly-noexcept

Conversation

@vitlibar
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Make the move operator for class ColumnDefault truly noexcept.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 15, 2025

Workflow [PR], commit [6b29f2e]

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 15, 2025
@vitlibar vitlibar changed the title Make the move operator of ColumnDefault truly noexcept Make the move operator for ColumnDefault truly noexcept Mar 15, 2025
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
@nikitamikhaylov nikitamikhaylov self-assigned this Mar 15, 2025
@nikitamikhaylov nikitamikhaylov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Mar 17, 2025
@nikitamikhaylov nikitamikhaylov added this pull request to the merge queue Mar 17, 2025
Merged via the queue into ClickHouse:master with commit d5fd57f Mar 17, 2025
119 of 124 checks passed
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 17, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Mar 17, 2025
Cherry pick #77670 to 24.3: Make the move operator for ColumnDefault truly noexcept
robot-clickhouse added a commit that referenced this pull request Mar 17, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Mar 17, 2025
Cherry pick #77670 to 24.8: Make the move operator for ColumnDefault truly noexcept
robot-clickhouse added a commit that referenced this pull request Mar 17, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Mar 17, 2025
Cherry pick #77670 to 24.12: Make the move operator for ColumnDefault truly noexcept
robot-clickhouse added a commit that referenced this pull request Mar 17, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Mar 17, 2025
Cherry pick #77670 to 25.1: Make the move operator for ColumnDefault truly noexcept
robot-clickhouse added a commit that referenced this pull request Mar 17, 2025
robot-ch-test-poll3 added a commit that referenced this pull request Mar 17, 2025
Cherry pick #77670 to 25.2: Make the move operator for ColumnDefault truly noexcept
robot-clickhouse added a commit that referenced this pull request Mar 17, 2025
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created-cloud deprecated label, NOOP label Mar 17, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 17, 2025
@alexey-milovidov
Copy link
Copy Markdown
Member

Why backporting?

@Algunenano
Copy link
Copy Markdown
Member

Same question as Alexey. Is this a bugfix (or even a critical bugfix)? If so, please mark it and document it as such

nikitamikhaylov added a commit that referenced this pull request Apr 7, 2025
Backport #77670 to 25.2: Make the move operator for ColumnDefault truly noexcept
nikitamikhaylov added a commit that referenced this pull request Apr 7, 2025
Backport #77670 to 25.1: Make the move operator for ColumnDefault truly noexcept
nikitamikhaylov added a commit that referenced this pull request Apr 7, 2025
Backport #77670 to 24.8: Make the move operator for ColumnDefault truly noexcept
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants