Start untangling Exception.h and Field.h by Algunenano · Pull Request #76299 · ClickHouse/ClickHouse

Algunenano · 2025-02-17T17:58:30Z

Changelog category (leave one):

Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Start untangling Exception.h and Field.h

Technically, this PR does little to nothing to improve compilation times. The idea is to start hiding Exception.h when possible, but the problem is that it's used in ~100 different headers so when you remove it from one you still get it from another one. Since the PR already contains ~250 changed files and touches some really common / used files, which could affect compilation and performance, let's do a quick check and merge this and continue later.

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

clickhouse-gh · 2025-02-17T17:58:57Z

Workflow [PR], commit [e8b8541]

Algunenano · 2025-02-19T08:32:39Z

Differences in perf tests might be related to the changes in Field::safeGet<>. Need to check

Checked. No noticeable differences locally. Same QPS at ~31

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

Algunenano added 8 commits February 17, 2025 18:53

Start hiding Exception.h

5da2585

Continue hiding Exception.h

be96da2

Continue hiding Exception.h

5105703

Continue hiding Exception.h

15bbbf6

Continue hiding Exception.h

825afa9

Continue hiding Exception.h

82d48aa

Simplify Field.h dependencies

c206f31

Continue hiding Exception.h

e057c39

clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Feb 17, 2025

Algunenano added 2 commits February 17, 2025 19:37

Fix fast build

0e3255e

Fix fast build linking

d736ee3

antaljanosbenjamin assigned antaljanosbenjamin and unassigned antaljanosbenjamin Feb 18, 2025

Algunenano added 2 commits February 18, 2025 12:31

Fix tidy

b78b8fd

Fix linking with Darwin

ec98b53

Algunenano assigned Algunenano and unassigned Algunenano Feb 18, 2025

Algunenano added 2 commits February 20, 2025 13:53

Merge remote-tracking branch 'blessed/master' into exception_compilation

b6457ca

Fix build after merge with master

e8b8541

Algunenano added the 🚀 Fast CI 🥒 A fast database deserves a fast CI label Feb 20, 2025

Algunenano enabled auto-merge February 20, 2025 18:58

Algunenano added this pull request to the merge queue Feb 20, 2025

Merged via the queue into ClickHouse:master with commit 2eded0e Feb 20, 2025
121 of 126 checks passed

Algunenano deleted the exception_compilation branch February 20, 2025 19:27

robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 20, 2025

baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Feb 21, 2025

insert range selective for shuffle write

bbf0c79

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

baibaichen added a commit to Kyligence/gluten that referenced this pull request Feb 21, 2025

Fix Build due to ClickHouse/ClickHouse#76299

2a6f41d

baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 18, 2025

insert range selective for shuffle write

3f1ef31

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 18, 2025

insert range selective for shuffle write

eab7a59

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 19, 2025

insert range selective for shuffle write

97e7d98

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 19, 2025

insert range selective for shuffle write

008df07

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 20, 2025

insert range selective for shuffle write

11be979

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 20, 2025

insert range selective for shuffle write

5a1025d

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 21, 2025

insert range selective for shuffle write

8565db4

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 22, 2025

insert range selective for shuffle write

b822a07

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 23, 2025

insert range selective for shuffle write

136c2fa

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 24, 2025

insert range selective for shuffle write

d4a8035

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 26, 2025

insert range selective for shuffle write

d53d754

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 26, 2025

insert range selective for shuffle write

780410c

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 27, 2025

insert range selective for shuffle write

9a0ff33

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 28, 2025

insert range selective for shuffle write

90ef6ae

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 29, 2025

insert range selective for shuffle write

c514053

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 30, 2025

insert range selective for shuffle write

80d8b90

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Mar 31, 2025

insert range selective for shuffle write

791618a

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 1, 2025

insert range selective for shuffle write

fccc121

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 2, 2025

insert range selective for shuffle write

f10e71a

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 3, 2025

insert range selective for shuffle write

8e8db6c

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 4, 2025

insert range selective for shuffle write

f44ed0e

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 5, 2025

insert range selective for shuffle write

2082fa7

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 6, 2025

insert range selective for shuffle write

b7b513c

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 7, 2025

insert range selective for shuffle write

cc0a49b

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

baibaichen pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 9, 2025

insert range selective for shuffle write

01abebc

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 9, 2025

insert range selective for shuffle write

97f63c8

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 10, 2025

insert range selective for shuffle write

aa189be

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 11, 2025

insert range selective for shuffle write

a084783

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 12, 2025

insert range selective for shuffle write

2ba0074

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

kyligence-git pushed a commit to Kyligence/ClickHouse that referenced this pull request Apr 13, 2025

insert range selective for shuffle write

0d87bee

(cherry picked from commit aa13a91) - 20250221 Fix Build due to ClickHouse#76299

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start untangling Exception.h and Field.h#76299

Start untangling Exception.h and Field.h#76299
Algunenano merged 14 commits intoClickHouse:masterfrom
Algunenano:exception_compilation

Algunenano commented Feb 17, 2025 •

edited

Loading

Uh oh!

clickhouse-gh bot commented Feb 17, 2025 •

edited

Loading

Uh oh!

Algunenano commented Feb 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Algunenano commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

Uh oh!

clickhouse-gh bot commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Algunenano commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Algunenano commented Feb 17, 2025 •

edited

Loading

clickhouse-gh bot commented Feb 17, 2025 •

edited

Loading

Algunenano commented Feb 19, 2025 •

edited

Loading