Merged
Conversation
akuzm
approved these changes
Oct 18, 2019
Contributor
akuzm
left a comment
There was a problem hiding this comment.
If it's a user-visible bug, the description for changelog should be in user terms (i.e. system.parts can show wrong records if there is a Lazy database).
If it isn't, we probably don't want to backport it, and can mark it as pr-build instead of pr-bugfix.
Member
Author
|
It rather leads to segfaults, sanitizer reports or exceptions like |
alexey-milovidov
approved these changes
Oct 19, 2019
Member
|
Contributor
|
backport conflict in 19.15 |
vitlibar
pushed a commit
that referenced
this pull request
Dec 26, 2019
Fix UB in StoragesInfoStream (cherry picked from commit 52bfa99)
vitlibar
pushed a commit
that referenced
this pull request
Dec 27, 2019
Fix UB in StoragesInfoStream (cherry picked from commit 52bfa99)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
offsets[i]was not been initialized forLazydatabases