Fix assert failure in SimpleSquashingChunksTransform by vdimir · Pull Request #72226 · ClickHouse/ClickHouse

vdimir · 2024-11-21T20:17:39Z

Changelog category (leave one):

Bug fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed a crash in SimpleSquashingChunksTransform that occurred in rare cases when processing sparse columns

Fix #72174

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

Allow: All Required Checks
Allow: Stateless tests
Allow: Stateful tests
Allow: Integration Tests
Allow: Performance tests
Allow: All Builds
Allow: batch 1, 2 for multi-batch jobs
Allow: batch 3, 4, 5, 6 for multi-batch jobs

Exclude: Style check
Exclude: Fast test
Exclude: All with ASAN
Exclude: All with TSAN, MSAN, UBSAN, Coverage
Exclude: All with aarch64, release, debug

Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
Exclude: AST fuzzers

robot-clickhouse-ci-2 · 2024-11-21T20:20:53Z

This is an automated comment for commit 2bea36c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Builds	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker keeper image	The check to build and optionally push the mentioned image to docker hub	✅ success
Docker server image	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

nickitat · 2024-11-21T20:25:46Z

src/Interpreters/Squashing.cpp

        for (size_t j = 0; j != num_columns; ++j)
        {
-            have_same_serialization[j] &= ISerialization::getKind(*columns[j]) == ISerialization::getKind(*mutable_columns[j]);
+            have_same_serialization[j] &= columns[j]->structureEquals(*mutable_columns[j]);


it deserves a comment explaining that difference in sparse-ness might be found within the column nested types (in case of Tuple), so we cannot just compare sparse-ness of the columns itself.

01172_transaction reproduces the issue #72174 (comment)

Not really stable, though. I'll try to create isolated one

vdimir · 2024-11-22T10:11:14Z

Stateless tests (release) — fail: 3, passed: 7247, skipped: 6 Details

Method structureEquals is not supported for Object

nickitat · 2024-11-22T15:19:13Z

maybe let's convert to bug-fix and backport

Cherry pick #72226 to 24.11: Fix assert failure in SimpleSquashingChunksTransform

…Transform

Backport #72226 to 24.11: Fix assert failure in SimpleSquashingChunksTransform

Cherry pick #72226 to 24.10: Fix assert failure in SimpleSquashingChunksTransform

…Transform

Backport #72226 to 24.10: Fix assert failure in SimpleSquashingChunksTransform

…t and non-const blocks It is possible to get const and non-const block after JOIN, so let's improve ClickHouse#72226 to convert column to full if the serilizations does not match, and add a test.

Fix assert failure in SimpleSquashingChunksTransform

…14/72226 24.8.14 Stable Backport of ClickHouse#72226: Fix assert failure in SimpleSquashingChunksTransform

Fix assert failure in SimpleSquashingChunksTransform

vdimir assigned nickitat Nov 21, 2024

robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 21, 2024

nickitat reviewed Nov 21, 2024

View reviewed changes

Fix #72174

c4329bf

vdimir force-pushed the vdimir/fix72174 branch from f0b729c to c4329bf Compare November 22, 2024 12:25

vdimir added 2 commits November 22, 2024 15:10

add test

fa94338

up

5abca62

nickitat approved these changes Nov 22, 2024

View reviewed changes

vdimir added the v24.11-must-backport label Nov 22, 2024

fix

2bea36c

vdimir added pr-bugfix Pull request with bugfix, not backported by default and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Nov 22, 2024

nickitat mentioned this pull request Nov 24, 2024

De-virtualize compareAt and getUInt calls in comparator for LowCardinality column #72337

Merged

21 tasks

nickitat changed the title ~~Fix #72174~~ Fix crash in SimpleSquashingChunksTransform Nov 24, 2024

nickitat changed the title ~~Fix crash in SimpleSquashingChunksTransform~~ Fix assert failure in SimpleSquashingChunksTransform Nov 24, 2024

vdimir added this pull request to the merge queue Nov 25, 2024

Merged via the queue into master with commit 6c1e44a Nov 25, 2024

vdimir deleted the vdimir/fix72174 branch November 25, 2024 09:48

robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 25, 2024

robot-ch-test-poll1 mentioned this pull request Nov 25, 2024

Cherry pick #72226 to 24.11: Fix assert failure in SimpleSquashingChunksTransform #72377

Merged

robot-ch-test-poll1 added a commit that referenced this pull request Nov 25, 2024

Merge pull request #72377 from ClickHouse/cherrypick/24.11/72226

0daafe8

Cherry pick #72226 to 24.11: Fix assert failure in SimpleSquashingChunksTransform

robot-clickhouse added a commit that referenced this pull request Nov 25, 2024

Backport #72226 to 24.11: Fix assert failure in SimpleSquashingChunks…

6ceca1f

…Transform

robot-ch-test-poll1 mentioned this pull request Nov 25, 2024

Backport #72226 to 24.11: Fix assert failure in SimpleSquashingChunksTransform #72378

Merged

robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Nov 25, 2024

robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 25, 2024

robot-ch-test-poll2 added a commit that referenced this pull request Nov 25, 2024

Merge pull request #72378 from ClickHouse/backport/24.11/72226

a11a0f4

Backport #72226 to 24.11: Fix assert failure in SimpleSquashingChunksTransform

vdimir mentioned this pull request Nov 25, 2024

Fix data race in Squashing with LowCardinality #72392

Merged

CurtizJ mentioned this pull request Dec 23, 2024

INSERT INTO ... SELECT ... involving a struct column segfaults #73726

Closed

CurtizJ added v24.10-must-backport and removed pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP labels Dec 23, 2024

robot-ch-test-poll3 mentioned this pull request Dec 23, 2024

Cherry pick #72226 to 24.10: Fix assert failure in SimpleSquashingChunksTransform #73734

Merged

robot-ch-test-poll3 added a commit that referenced this pull request Dec 23, 2024

Merge pull request #73734 from ClickHouse/cherrypick/24.10/72226

0f78a77

Cherry pick #72226 to 24.10: Fix assert failure in SimpleSquashingChunksTransform

robot-clickhouse added a commit that referenced this pull request Dec 23, 2024

Backport #72226 to 24.10: Fix assert failure in SimpleSquashingChunks…

2755a90

…Transform

robot-ch-test-poll3 mentioned this pull request Dec 23, 2024

Backport #72226 to 24.10: Fix assert failure in SimpleSquashingChunksTransform #73735

Merged

robot-clickhouse-ci-2 added the pr-backports-created-cloud deprecated label, NOOP label Dec 23, 2024

robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 23, 2024

CurtizJ added a commit that referenced this pull request Dec 24, 2024

Merge pull request #73735 from ClickHouse/backport/24.10/72226

ee99db6

Backport #72226 to 24.10: Fix assert failure in SimpleSquashingChunksTransform

azat mentioned this pull request Sep 15, 2025

Issue after upgrading from ClickHouse 22.10.7 to 24.8.5 in Kubernetes #72544

Closed

azat mentioned this pull request Sep 17, 2025

Fix "Too large size passed to allocator" UB in JOIN due to mixed const and non-const blocks #87231

Merged

aadant mentioned this pull request Feb 12, 2026

While executing SimpleSquashingTransform. (PARAMETER_OUT_OF_BOUND) (version 24.8.2.3 (official build)) #69410

Closed

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Feb 13, 2026

Merge pull request ClickHouse#72226 from ClickHouse/vdimir/fix72174

009359d

Fix assert failure in SimpleSquashingChunksTransform

zvonand mentioned this pull request Feb 13, 2026

24.8.14 Stable Backport of #72226: Fix assert failure in SimpleSquashingChunksTransform Altinity/ClickHouse#1399

Merged

25 tasks

zvonand added a commit to Altinity/ClickHouse that referenced this pull request Feb 20, 2026

Merge pull request #1399 from Altinity/backports/customizations/24.8.…

2ad360a

…14/72226 24.8.14 Stable Backport of ClickHouse#72226: Fix assert failure in SimpleSquashingChunksTransform

zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Mar 17, 2026

Merge pull request ClickHouse#72226 from ClickHouse/vdimir/fix72174

199ae31

Fix assert failure in SimpleSquashingChunksTransform

zvonand mentioned this pull request Mar 17, 2026

24.8.14 Stable Pre-Release PR Altinity/ClickHouse#1540

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix assert failure in SimpleSquashingChunksTransform#72226

Fix assert failure in SimpleSquashingChunksTransform#72226
vdimir merged 4 commits intomasterfrom
vdimir/fix72174

vdimir commented Nov 21, 2024 •

edited

Loading

Uh oh!

robot-clickhouse-ci-2 commented Nov 21, 2024 •

edited by robot-ch-test-poll1

Loading

Uh oh!

nickitat Nov 21, 2024

Uh oh!

alexey-milovidov Nov 22, 2024

Uh oh!

vdimir Nov 22, 2024

Uh oh!

vdimir Nov 22, 2024

Uh oh!

vdimir commented Nov 22, 2024

Uh oh!

nickitat commented Nov 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

vdimir commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Documentation entry for user-facing changes

CI Settings (Only check the boxes if you know what you are doing):

Uh oh!

robot-clickhouse-ci-2 commented Nov 21, 2024 • edited by robot-ch-test-poll1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickitat Nov 21, 2024

Choose a reason for hiding this comment

Uh oh!

alexey-milovidov Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

vdimir Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

vdimir Nov 22, 2024

Choose a reason for hiding this comment

Uh oh!

vdimir commented Nov 22, 2024

Uh oh!

nickitat commented Nov 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

vdimir commented Nov 21, 2024 •

edited

Loading

robot-clickhouse-ci-2 commented Nov 21, 2024 •

edited by robot-ch-test-poll1

Loading