Skip to content

Fix CREATE TABLE AS from table with virtual columns#7183

Merged
abyss7 merged 7 commits intoClickHouse:masterfrom
abyss7:fix-virtual-columns
Oct 17, 2019
Merged

Fix CREATE TABLE AS from table with virtual columns#7183
abyss7 merged 7 commits intoClickHouse:masterfrom
abyss7:fix-virtual-columns

Conversation

@abyss7
Copy link
Copy Markdown
Contributor

@abyss7 abyss7 commented Oct 3, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

For changelog. Remove if this is non-significant change.

Category (leave one):

  • Bug Fix

Short description (up to few sentences):
Don't put virtual columns to .sql metadata when table is create as CREATE TABLE AS

@abyss7 abyss7 self-assigned this Oct 3, 2019
@abyss7 abyss7 added the pr-bugfix Pull request with bugfix, not backported by default label Oct 3, 2019
@abyss7 abyss7 force-pushed the fix-virtual-columns branch from 3335186 to c6591b1 Compare October 8, 2019 09:16
@abyss7 abyss7 changed the title Multiple fixes about virtual columns Fix CREATE TABLE AS from table with virtual columns Oct 10, 2019
@abyss7 abyss7 marked this pull request as ready for review October 10, 2019 13:05
@abyss7 abyss7 requested a review from alesapin October 15, 2019 14:44
@abyss7 abyss7 merged commit e595df0 into ClickHouse:master Oct 17, 2019
@abyss7 abyss7 deleted the fix-virtual-columns branch October 17, 2019 11:12
@akuzm
Copy link
Copy Markdown
Contributor

akuzm commented Oct 29, 2019

backport conflict in 19.15

tavplubix pushed a commit that referenced this pull request Nov 19, 2019
* Disable undefined instrumentation for rdkafka
vitlibar pushed a commit that referenced this pull request Dec 26, 2019
* Disable undefined instrumentation for rdkafka

(cherry picked from commit e595df0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants