Skip to content

Revert "Selection of hash join inner table"#71527

Merged
Algunenano merged 2 commits intomasterfrom
revert-68682-vdimir/join_select_inner_table
Nov 6, 2024
Merged

Revert "Selection of hash join inner table"#71527
Algunenano merged 2 commits intomasterfrom
revert-68682-vdimir/join_select_inner_table

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented Nov 6, 2024 •
edited
Loading

Reverts #68682

Broke some queries. Closes #71507. Closes #71454

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 6, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented Nov 6, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 4e30cf7 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Algunenano Algunenano self-assigned this Nov 6, 2024
@Algunenano Algunenano mentioned this pull request Nov 6, 2024
Closed
@Algunenano Algunenano enabled auto-merge November 6, 2024 18:22
@Algunenano Algunenano added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit dd5061a Nov 6, 2024
@Algunenano Algunenano deleted the revert-68682-vdimir/join_select_inner_table branch November 6, 2024 19:49
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 6, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 7, 2024
@baibaichen
Revert "Fix Build due to ClickHouse/ClickHouse#68682", see ClickHouse…
640f108 
…/ClickHouse#71527
baibaichen added a commit to apache/gluten that referenced this pull request Nov 7, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241107) (#7835)
f16915b 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241107)

* Revert "Fix Build due to ClickHouse/ClickHouse#68682", see ClickHouse/ClickHouse#71527

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
vdimir added a commit that referenced this pull request Nov 7, 2024
@vdimir
Revert "Merge pull request #71527 from ClickHouse/revert-68682-vdimir…
0fb51df 
…/join_select_inner_table"

This reverts commit dd5061a, reversing
changes made to 0011bc5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Algunenano Algunenano

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Paste join with Group by logical error Logical error: 'Unexpected number of columns in result sample block: 4 instead of 1 (1 + 0 + 0)'.

4 participants

@Algunenano @robot-ch-test-poll4 @robot-ch-test-poll1 @robot-ch-test-poll3