Skip to content

Fix memory usage increase bug in 24.10 during remote read#71261

Merged
kssenii merged 5 commits intomasterfrom
fix-memory-usage-in-read-buffer-from-remote-fs-gather
Nov 4, 2024
Merged

Fix memory usage increase bug in 24.10 during remote read#71261
kssenii merged 5 commits intomasterfrom
fix-memory-usage-in-read-buffer-from-remote-fs-gather

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Oct 30, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix bug of memory usage increase if enable_filesystem_cache=1, but disk in storage configuration did not have any cache configuration.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label Oct 30, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Oct 30, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit 390429d with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@nickitat nickitat self-assigned this Oct 30, 2024
@kssenii
Copy link
Copy Markdown
Member Author

kssenii commented Nov 4, 2024 •
edited
Loading

Stateless tests (debug, s3 storage) — fail: 1

03036_dynamic_read_shared_subcolumns_wide_merge_tree -- fails in master (example), under investigation

Stateless tests (debug) [2/2] — fail: 1

02456_progress_tty #48693

Stateless tests (msan) [3/4]

01275_parallel_mv #66116

@kssenii kssenii added this pull request to the merge queue Nov 4, 2024
Merged via the queue into master with commit e3bb7a3 Nov 4, 2024
@kssenii kssenii deleted the fix-memory-usage-in-read-buffer-from-remote-fs-gather branch November 4, 2024 15:16
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 4, 2024
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Nov 4, 2024
Merged
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 5, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#71261
34cd313
baibaichen added a commit to apache/gluten that referenced this pull request Nov 5, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241105) (#7809)
34a88dd 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241105)

* Fix Build due to ClickHouse/ClickHouse#71261

* Fix Build due to ClickHouse/ClickHouse#68682

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Nov 5, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request Nov 5, 2024
@robot-clickhouse-ci-1
Merge pull request #71427 from ClickHouse/cherrypick/24.10/e3bb7a38f1…
a477407 
…efce03deafbab3103d4b329c9ea50d

Cherry pick #71261 to 24.10: Fix memory usage increase bug in 24.10 during remote read
robot-clickhouse added a commit that referenced this pull request Nov 5, 2024
@robot-clickhouse
Backport #71261 to 24.10: Fix memory usage increase bug in 24.10 duri…
f6e8b35 
…ng remote read
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Nov 5, 2024
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 5, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Nov 7, 2024
@robot-clickhouse-ci-2
Merge pull request #71467 from ClickHouse/backport/24.10/71261
add4c7e 
Backport #71261 to 24.10: Fix memory usage increase bug in 24.10 during remote read
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickitat nickitat nickitat approved these changes

Assignees

@nickitat nickitat

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kssenii @robot-clickhouse @nickitat @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-ch-test-poll4