Skip to content

Follow-up on clickhouse-client realtime metrics display #63689#70423

Merged
jkartseva merged 2 commits intomasterfrom
realtime-metrics-followup
Oct 7, 2024
Merged

Follow-up on clickhouse-client realtime metrics display #63689#70423
jkartseva merged 2 commits intomasterfrom
realtime-metrics-followup

Conversation

@jkartseva
Copy link
Copy Markdown
Member

@jkartseva jkartseva commented Oct 6, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

clickhouse-client realtime metrics follow-up: restore cursor when Ctrl-C cancels query; immediately stop intercepting keystrokes when the query is canceled; display the metrics table if --progress-table is on, and toggling is disabled.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@jkartseva
fix cursor display
2d8bda0 
Restore cursor when query is canceled by Ctrl-C.
Immediately stop intercepting keystrokes after SIGINT is received.
@jkartseva
display progress table if toggling is disabled
3668258
@jkartseva jkartseva added the can be tested Allows running workflows for external contributors label Oct 6, 2024
@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Oct 6, 2024
@robot-ch-test-poll3
Copy link
Copy Markdown
Contributor

robot-ch-test-poll3 commented Oct 6, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit 3668258 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@davenger davenger self-assigned this Oct 7, 2024
@jkartseva jkartseva added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit a98fca0 Oct 7, 2024
@jkartseva jkartseva deleted the realtime-metrics-followup branch October 7, 2024 05:36
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 7, 2024
azat added a commit to azat/ClickHouse that referenced this pull request Oct 7, 2024
@azat
Fix 0.1 second delay for interactive queries (due to keystroke interc…
3f873f1 
…eptor)

Introduced in ClickHouse#63689, improved from 0.3 to 0.1 in ClickHouse#70423 with condvar.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat azat mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davenger davenger davenger approved these changes

Assignees

@davenger davenger

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkartseva @robot-ch-test-poll3 @davenger @robot-ch-test-poll @robot-ch-test-poll1