Skip to content

Allow to cache read files for object storage table engines and data lakes using hash from ETag and file path as cache key#70135

Merged
kssenii merged 16 commits intomasterfrom
cache-for-object-storage-table-engines
Oct 14, 2024
Merged

Allow to cache read files for object storage table engines and data lakes using hash from ETag and file path as cache key#70135
kssenii merged 16 commits intomasterfrom
cache-for-object-storage-table-engines

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Sep 30, 2024 •
edited
Loading

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow to cache read files for object storage table engines and data lakes using hash from ETag + file path as cache key

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse robot-clickhouse added the pr-feature Pull request with new product feature label Sep 30, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Sep 30, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit 619f60b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@kssenii kssenii force-pushed the cache-for-object-storage-table-engines branch from 9d900fd to 69cd987 Compare September 30, 2024 19:17
@kssenii kssenii mentioned this pull request Oct 1, 2024
Merged
21 tasks
@Avogar Avogar self-assigned this Oct 1, 2024
@kssenii kssenii marked this pull request as ready for review October 3, 2024 16:01
@kssenii kssenii added this pull request to the merge queue Oct 14, 2024
Merged via the queue into master with commit ad7c74c Oct 14, 2024
@kssenii kssenii deleted the cache-for-object-storage-table-engines branch October 14, 2024 14:48
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Oct 14, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Oct 15, 2024
@baibaichen
Fix Build due to ClickHouse/ClickHouse#70135
86e962a
baibaichen added a commit to apache/gluten that referenced this pull request Oct 15, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241015) (#7529)
d9d0de8 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241015)

* Fix Build due to ClickHouse/ClickHouse#70135

* Resovle conflict with #7322

* gtest skip since plan is chagned due to #7395

(cherry picked from commit 94e1837a922d5a092226b195d6c3079d320878cb)

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kssenii @robot-ch-test-poll2 @Avogar @robot-clickhouse