Skip to content

Change the join_to_sort settings type to unsigned int#69886

Merged
Algunenano merged 2 commits intoClickHouse:masterfrom
KevinyhZou:fix_data_type_of_join_to_sort_settings
Sep 24, 2024
Merged

Change the join_to_sort settings type to unsigned int#69886
Algunenano merged 2 commits intoClickHouse:masterfrom
KevinyhZou:fix_data_type_of_join_to_sort_settings

Conversation

@KevinyhZou
Copy link
Copy Markdown
Contributor

@KevinyhZou KevinyhZou commented Sep 24, 2024

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Change the join to sort settings type to unsigned int

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Run only fuzzers related jobs (libFuzzer fuzzers, AST fuzzers, etc.)
  • Exclude: AST fuzzers
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@KevinyhZou KevinyhZou changed the title Change the join to sort settings type to unsigned int Change the join_to_sort settings type to unsigned int Sep 24, 2024
@KevinyhZou
Copy link
Copy Markdown
Contributor Author

KevinyhZou commented Sep 24, 2024

cc @Algunenano

@KevinyhZou KevinyhZou force-pushed the fix_data_type_of_join_to_sort_settings branch from a7644cb to 56fec19 Compare September 24, 2024 02:00
@KevinyhZou KevinyhZou mentioned this pull request Sep 24, 2024
Merged
1 task
@jkartseva jkartseva added the can be tested Allows running workflows for external contributors label Sep 24, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-improvement Pull request with some product improvements label Sep 24, 2024
@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Sep 24, 2024 •
edited
Loading

This is an automated comment for commit a481d18 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Algunenano Algunenano self-assigned this Sep 24, 2024
@Algunenano Algunenano mentioned this pull request Sep 24, 2024
Closed
@Algunenano Algunenano added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@Algunenano Algunenano added this pull request to the merge queue Sep 24, 2024
Merged via the queue into ClickHouse:master with commit a6a707d Sep 24, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 24, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Sep 24, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Sep 24, 2024
@robot-clickhouse
Backport #69886 to 24.9: Change the join_to_sort settings type to uns…
430850a 
…igned int
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Sep 24, 2024
Merged
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 24, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created-cloud deprecated label, NOOP label Sep 24, 2024
robot-ch-test-poll added a commit that referenced this pull request Sep 24, 2024
@robot-ch-test-poll
Merge pull request #69905 from ClickHouse/backport/24.9/69886
dfb19d6 
Backport #69886 to 24.9: Change the join_to_sort settings type to unsigned int
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Algunenano Algunenano

Labels

can be tested Allows running workflows for external contributors pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@KevinyhZou @robot-ch-test-poll1 @Algunenano @jkartseva @robot-ch-test-poll4 @robot-clickhouse-ci-1