Skip to content

Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing#67904

Merged
rschu1ze merged 7 commits intoClickHouse:masterfrom
rschu1ze:bump-rocksdb3
Aug 7, 2024
Merged

Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing#67904
rschu1ze merged 7 commits intoClickHouse:masterfrom
rschu1ze:bump-rocksdb3

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Aug 6, 2024

Follow-up for #66479, includes jemalloc- and liburing-enabling bits from #67274 (cc: @canhld94)

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Aug 6, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Aug 6, 2024 •
edited by robot-ch-test-poll2
Loading

This is an automated comment for commit df0dac2 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@rschu1ze rschu1ze changed the title Bump rocksdb from v8.10 to 9.4 + enable jemalloc and liburing Bump rocksdb from v8.10 to v9.4 + enable jemalloc and liburing Aug 6, 2024
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Aug 7, 2024

ClickHouse Stateless tests (aarch64) (02310_clickhouse_local_INSERT_progress_profile_events): #67961

@hanfei1991 hanfei1991 self-assigned this Aug 7, 2024
@rschu1ze rschu1ze added this pull request to the merge queue Aug 7, 2024
Merged via the queue into ClickHouse:master with commit 681014d Aug 7, 2024
@rschu1ze rschu1ze deleted the bump-rocksdb3 branch August 7, 2024 15:11
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 7, 2024
@nikitamikhaylov nikitamikhaylov mentioned this pull request Aug 7, 2024
Merged
@rschu1ze rschu1ze mentioned this pull request Aug 8, 2024
Merged
canhld94
canhld94 reviewed Aug 8, 2024
View reviewed changes
contrib/rocksdb-cmake/CMakeLists.txt
option(WITH_ZSTD "build with zstd" ON)

if(WITH_SNAPPY)
if (ENABLE_JEMALLOC)
Copy link
Copy Markdown
Contributor

@canhld94 canhld94 Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be like this to fix BSD build:

if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" AND NOT CMAKE_SYSTEM_NAME MATCHES "kFreeBSD")
  # FreeBSD has jemalloc as default malloc
  # but it does not have all the jemalloc files in include/...
else()
  if (ENABLE_JEMALLOC)
        message (STATUS "Using jemalloc")
        target_compile_definitions (_rocksdb PUBLIC ROCKSDB_JEMALLOC JEMALLOC_NO_DEMANGLE)
        list (APPEND THIRDPARTY_LIBS ch_contrib::jemalloc)
  endif ()
endif ()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

+1 more reviewer

@canhld94 canhld94 canhld94 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hanfei1991 hanfei1991

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rschu1ze @robot-clickhouse @hanfei1991 @canhld94 @robot-clickhouse-ci-1