Skip to content

Fix timeout of 02310_clickhouse_local_INSERT_progress_profile_events#67961

Merged
rschu1ze merged 1 commit intoClickHouse:masterfrom
rschu1ze:wreck-a-test
Aug 7, 2024
Merged

Fix timeout of 02310_clickhouse_local_INSERT_progress_profile_events#67961
rschu1ze merged 1 commit intoClickHouse:masterfrom
rschu1ze:wreck-a-test

Conversation

@rschu1ze
Copy link
Copy Markdown
Member

@rschu1ze rschu1ze commented Aug 7, 2024

Addresses a timeout of 02310_clickhouse_local_INSERT_progress_profile_events:

https://s3.amazonaws.com/clickhouse-test-reports/67904/df0dac2f5b509438cce28214b78765c46439aa8c/stateless_tests__aarch64_.html

This PR "fixes" the problem in a similar way as #67264

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@rschu1ze rschu1ze changed the title Make it worse Fix timeout of 02310_clickhouse_local_INSERT_progress_profile_events Aug 7, 2024
@rschu1ze rschu1ze mentioned this pull request Aug 7, 2024
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Aug 7, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Aug 7, 2024 •
edited by robot-ch-test-poll3
Loading

This is an automated comment for commit ead9dc4 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@evillique evillique self-assigned this Aug 7, 2024
@rschu1ze
Copy link
Copy Markdown
Member Author

rschu1ze commented Aug 7, 2024

Tests ran into #67769, checking it separately.
Let me merge anyways since the PR is trivial.

@rschu1ze rschu1ze added this pull request to the merge queue Aug 7, 2024
Merged via the queue into ClickHouse:master with commit de9cded Aug 7, 2024
@rschu1ze rschu1ze deleted the wreck-a-test branch August 7, 2024 13:54
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 7, 2024
This was referenced Oct 24, 2024
Merged
Closed
@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rschu1ze @robot-clickhouse @evillique @alexey-milovidov @robot-ch-test-poll1 @robot-ch-test-poll2