Skip to content

Analyzer: Do not traverse unresolved subtrees#67522

Merged
novikd merged 5 commits intomasterfrom
analyzer-fix-replace-with-dummy-table
Aug 5, 2024
Merged

Analyzer: Do not traverse unresolved subtrees#67522
novikd merged 5 commits intomasterfrom
analyzer-fix-replace-with-dummy-table

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Jul 31, 2024

Changelog category (leave one):

  • Critical Bug Fix (crash, LOGICAL_ERROR, data loss, RBAC)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixes #66026. Avoid unresolved table function arguments traversal in ReplaceTableNodeToDummyVisitor.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll robot-ch-test-poll added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jul 31, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 31, 2024 •
edited by robot-clickhouse
Loading

This is an automated comment for commit 3a868fc with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 31, 2024
@novikd novikd added the analyzer Issues and pull-requests related to new analyzer label Aug 1, 2024
@alexey-milovidov alexey-milovidov mentioned this pull request Aug 1, 2024
Merged
18 tasks
@alexey-milovidov alexey-milovidov self-assigned this Aug 1, 2024
@novikd novikd added this pull request to the merge queue Aug 5, 2024
Merged via the queue into master with commit f5b4e4d Aug 5, 2024
@novikd novikd deleted the analyzer-fix-replace-with-dummy-table branch August 5, 2024 14:43
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Aug 5, 2024
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 5, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Aug 5, 2024
@robot-clickhouse
Backport #67522 to 23.8: Analyzer: Do not traverse unresolved subtrees
3aefce1
This was referenced Aug 5, 2024
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Aug 5, 2024
@robot-clickhouse
Backport #67522 to 24.3: Analyzer: Do not traverse unresolved subtrees
dd81f62
This was referenced Aug 5, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Aug 5, 2024
@robot-clickhouse
Backport #67522 to 24.5: Analyzer: Do not traverse unresolved subtrees
99f3117
This was referenced Aug 5, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Aug 5, 2024
@robot-clickhouse
Backport #67522 to 24.6: Analyzer: Do not traverse unresolved subtrees
123dc34
This was referenced Aug 5, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Aug 5, 2024
@robot-clickhouse
Backport #67522 to 24.7: Analyzer: Do not traverse unresolved subtrees
beaa87c
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 5, 2024
Merged
robot-clickhouse-ci-1 added a commit that referenced this pull request Aug 5, 2024
@robot-clickhouse-ci-1
Merge pull request #67850 from ClickHouse/backport/24.5/67522
8fd3673 
Backport #67522 to 24.5: Analyzer: Do not traverse unresolved subtrees
robot-ch-test-poll2 added a commit that referenced this pull request Aug 5, 2024
@robot-ch-test-poll2
Merge pull request #67852 from ClickHouse/backport/24.6/67522
1d4b585 
Backport #67522 to 24.6: Analyzer: Do not traverse unresolved subtrees
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 5, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Aug 5, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Aug 5, 2024
@robot-clickhouse-ci-2
Merge pull request #67854 from ClickHouse/backport/24.7/67522
d25941c 
Backport #67522 to 24.7: Analyzer: Do not traverse unresolved subtrees
robot-clickhouse-ci-1 added a commit that referenced this pull request Aug 7, 2024
@robot-clickhouse-ci-1
Merge pull request #67848 from ClickHouse/backport/24.3/67522
7768bae 
Backport #67522 to 24.3: Analyzer: Do not traverse unresolved subtrees
@maxknv
Copy link
Copy Markdown
Member

maxknv commented Aug 7, 2024

TODO: fix backport scripts and repeat backporting

@novikd novikd mentioned this pull request Aug 20, 2024
Merged
novikd added a commit that referenced this pull request Aug 20, 2024
@novikd
Backport #67522 to 24.3: Analyzer: Do not traverse unresolved subtrees
de7013c
novikd added a commit that referenced this pull request Aug 20, 2024
@novikd
Backport #67522 to 24.6: Analyzer: Do not traverse unresolved subtrees
8cdcaaa
@novikd novikd mentioned this pull request Aug 20, 2024
Merged
novikd added a commit that referenced this pull request Aug 20, 2024
@novikd
Backport #67522 to 24.7: Analyzer: Do not traverse unresolved subtrees
2f92b73
@novikd novikd mentioned this pull request Aug 20, 2024
Merged
@novikd
Copy link
Copy Markdown
Member Author

novikd commented Aug 20, 2024

Created correct backport PRs manually

robot-ch-test-poll2 added a commit that referenced this pull request Aug 20, 2024
@robot-ch-test-poll2
Merge pull request #68609 from ClickHouse/backport/24.3/67522
ff2ecc5 
[Manual] Backport #67522 to 24.3
robot-clickhouse-ci-1 added a commit that referenced this pull request Aug 20, 2024
@robot-clickhouse-ci-1
Merge pull request #68613 from ClickHouse/backport/24.7/67522
ab8048e 
[Manual] Backport #67522 to 24.7
novikd added a commit that referenced this pull request Aug 21, 2024
@novikd
Merge pull request #68611 from ClickHouse/backport/24.6/67522
a09e812 
[Manual] Backport #67522 to 24.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

analyzer Issues and pull-requests related to new analyzer 🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Analyzer: Table function node numbers_mt is not resolved

7 participants

@novikd @robot-ch-test-poll @maxknv @alexey-milovidov @robot-ch-test-poll2 @robot-ch-test-poll4 @robot-ch-test-poll3