Skip to content

[CI Fest] Split dynamic tests and rewrite them from sh to sql to avoid timeouts#66981

Merged
Avogar merged 1 commit intoClickHouse:masterfrom
Avogar:split-dynamic-merges-test
Jul 24, 2024
Merged

[CI Fest] Split dynamic tests and rewrite them from sh to sql to avoid timeouts#66981
Avogar merged 1 commit intoClickHouse:masterfrom
Avogar:split-dynamic-merges-test

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jul 23, 2024

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

While reading the logs of these tests with timeouts I noticed that in most cases the queries itself are quite fast but the TCPHandler handles requests really slow and these tests contain quite a lot of connections. Rewriting them to .sql should speed up them significantly.
Closes #66048

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 23, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Jul 23, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit 0324869 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

evillique
evillique approved these changes Jul 23, 2024
View reviewed changes
tests/queries/0_stateless/03036_dynamic_read_subcolumns.sh
function test()
{
echo "test"
$CH_CLIENT -q "insert into test select number, number from numbers(100000) settings min_insert_block_size_rows=50000"
Copy link
Copy Markdown
Member

@evillique evillique Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an option, you can merge all the queries inside test() into a single query to not duplicate the tests. But if it would still timeout then it is ok :)

Copy link
Copy Markdown
Member Author

@Avogar Avogar Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First I also thougth about it, but decided to split and rewrite everything to sql test to just forget about this problem with timeouts. I think a bit duplicated queries in tests is better then flaky tests :)

@evillique evillique self-assigned this Jul 23, 2024
@Avogar Avogar added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Jul 24, 2024

Stateless tests (aarch64) — fail: 1

#48693

@Avogar Avogar added this pull request to the merge queue Jul 24, 2024
Merged via the queue into ClickHouse:master with commit 911104d Jul 24, 2024
@Avogar Avogar deleted the split-dynamic-merges-test branch July 24, 2024 11:31
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 24, 2024
@Avogar Avogar mentioned this pull request Jul 25, 2024
Merged
18 tasks
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created-cloud deprecated label, NOOP label Jul 26, 2024
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jul 26, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Jul 26, 2024
@robot-clickhouse
Backport #66981 to 24.7: [CI Fest] Split dynamic tests and rewrite th…
7d30223 
…em from sh to sql to avoid timeouts
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 mentioned this pull request Jul 26, 2024
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 26, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Jul 26, 2024
@robot-clickhouse-ci-2
Merge pull request #67213 from ClickHouse/backport/24.7/66981
9e85837 
Backport #66981 to 24.7: [CI Fest] Split dynamic tests and rewrite them from sh to sql to avoid timeouts
This was referenced Jul 29, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky 03037_dynamic_merges_1_vertical

6 participants

@Avogar @robot-ch-test-poll2 @evillique @robot-ch-test-poll @robot-ch-test-poll1 @robot-clickhouse-ci-2