Skip to content

Fix possible PARAMETER_OUT_OF_BOUND error during reading variant subcolumn#66659

Merged
Avogar merged 2 commits intomasterfrom
Avogar-patch-6
Jul 19, 2024
Merged

Fix possible PARAMETER_OUT_OF_BOUND error during reading variant subcolumn#66659
Avogar merged 2 commits intomasterfrom
Avogar-patch-6

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Jul 17, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix possible PARAMETER_OUT_OF_BOUND error during reading variant subcolumn.

Closes #65319

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Jul 17, 2024
Avogar
Avogar commented Jul 17, 2024
View reviewed changes
src/DataTypes/Serializations/SerializationVariantElement.cpp
}

/// If nothing to deserialize, just insert defaults.
if (variant_limit == 0)
Copy link
Copy Markdown
Member Author

@Avogar Avogar Jul 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was here. We didn't call nested_serialization->deserializeBinaryBulkWithMultipleStreams when there was 0 rows to read. But it's wrong, we should call it anywhay to seek the corresponding stream to the right mark if needed.

@robot-ch-test-poll1
Copy link
Copy Markdown
Contributor

robot-ch-test-poll1 commented Jul 17, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit bd29313 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@nikitamikhaylov nikitamikhaylov self-assigned this Jul 17, 2024
@nikitamikhaylov nikitamikhaylov mentioned this pull request Jul 17, 2024
Merged
19 tasks
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Jul 19, 2024

Stateless tests (msan) [2/3]/Stateless tests (tsan, s3 storage) [2/3] - #47866

@Avogar Avogar added this pull request to the merge queue Jul 19, 2024
Merged via the queue into master with commit 0d00e84 Jul 19, 2024
@Avogar Avogar deleted the Avogar-patch-6 branch July 19, 2024 11:05
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 19, 2024
@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Aug 6, 2024
This was referenced Aug 6, 2024
Closed
Merged
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Aug 9, 2024
@robot-clickhouse
Backport #66659 to 24.3: Fix possible PARAMETER_OUT_OF_BOUND error du…
135f08e 
…ring reading variant subcolumn
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 9, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Aug 9, 2024
@robot-clickhouse
Backport #66659 to 24.5: Fix possible PARAMETER_OUT_OF_BOUND error du…
e0be2a2 
…ring reading variant subcolumn
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 9, 2024
Merged
robot-clickhouse added a commit that referenced this pull request Aug 9, 2024
@robot-clickhouse
Backport #66659 to 24.6: Fix possible PARAMETER_OUT_OF_BOUND error du…
aabe633 
…ring reading variant subcolumn
@robot-clickhouse robot-clickhouse mentioned this pull request Aug 9, 2024
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 9, 2024
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created-cloud deprecated label, NOOP label Aug 12, 2024
@the4thamigo-uk
Copy link
Copy Markdown

the4thamigo-uk commented Aug 14, 2024

@nikitamikhaylov The backport to 24.3 is failing. We are hitting this issue and we need this fix as soon as possible. Any chance someone could look into it?

https://github.com/ClickHouse/ClickHouse/pulls?q=is%3Apr+PARAMETER_OUT_OF_BOUND

robot-clickhouse added a commit that referenced this pull request Aug 15, 2024
@robot-clickhouse
Merge pull request #68115 from ClickHouse/backport/24.5/66659
00ed6c0 
Backport #66659 to 24.5: Fix possible PARAMETER_OUT_OF_BOUND error during reading variant subcolumn
Avogar added a commit that referenced this pull request Aug 15, 2024
@Avogar
Merge pull request #68114 from ClickHouse/backport/24.3/66659
0c99c4d 
Backport #66659 to 24.3: Fix possible PARAMETER_OUT_OF_BOUND error during reading variant subcolumn
Avogar added a commit that referenced this pull request Aug 21, 2024
@Avogar
Merge pull request #68116 from ClickHouse/backport/24.6/66659
823261a 
Backport #66659 to 24.6: Fix possible PARAMETER_OUT_OF_BOUND error during reading variant subcolumn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parameter out of bound in IColumnString::insertRangeFrom (03036_dynamic_read_subcolumns)

7 participants

@Avogar @robot-ch-test-poll1 @the4thamigo-uk @nikitamikhaylov @robot-clickhouse @robot-ch-test-poll3 @robot-clickhouse-ci-2