Skip to content

Analyzer: identifier resolution in parent scopes#66143

Merged
novikd merged 83 commits intomasterfrom
fix-analyzer-resolve-in-parent-scope
Feb 7, 2025
Merged

Analyzer: identifier resolution in parent scopes#66143
novikd merged 83 commits intomasterfrom
fix-analyzer-resolve-in-parent-scope

Conversation

@novikd
Copy link
Copy Markdown
Member

@novikd novikd commented Jul 5, 2024 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix identifier resolution from parent scopes. Allow the use of aliases to expressions in the WITH clause.
Fixes #58994.
Fixes #62946.
Fixes #63239.
Fixes #65233.
Fixes #71659.
Fixes #71828.
Fixes #68749.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@novikd novikd added the analyzer Issues and pull-requests related to new analyzer label Jul 5, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Jul 5, 2024
@robot-clickhouse-ci-1
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-1 commented Jul 5, 2024 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit 57a3b91 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success

@novikd novikd force-pushed the fix-analyzer-resolve-in-parent-scope branch from d07fb46 to e23c981 Compare August 22, 2024 15:46
novikd added 16 commits August 22, 2024 17:57
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 7, 2025
@azat azat mentioned this pull request Feb 10, 2025
Closed
@novikd novikd added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Feb 11, 2025
This was referenced Feb 11, 2025
Closed
Closed
Closed
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Feb 11, 2025
@robot-ch-test-poll3
Merge pull request #75903 from ClickHouse/cherrypick/25.1/66143
5d0a7df 
Cherry pick #66143 to 25.1: Analyzer: identifier resolution in parent scopes
robot-clickhouse added a commit that referenced this pull request Feb 11, 2025
@robot-clickhouse
Backport #66143 to 25.1: Analyzer: identifier resolution in parent sc…
f079dc8 
…opes
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 11, 2025
Closed
robot-ch-test-poll2 added a commit that referenced this pull request Feb 11, 2025
@robot-ch-test-poll2
Merge pull request #75902 from ClickHouse/cherrypick/24.12/66143
2002ccc 
Cherry pick #66143 to 24.12: Analyzer: identifier resolution in parent scopes
robot-clickhouse added a commit that referenced this pull request Feb 11, 2025
@robot-clickhouse
Backport #66143 to 24.12: Analyzer: identifier resolution in parent s…
88e14b1 
…copes
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Feb 11, 2025
Closed
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Feb 11, 2025

Backporting has a risk of breaking customers' queries, do we have to do it?

@novikd
Copy link
Copy Markdown
Member Author

novikd commented Feb 13, 2025

This PR has fixed many queries. Even without taking this into account, I still see backporting as necessary because we want to be able to backport other fixes in the future.

rschu1ze added a commit to rschu1ze/ClickHouse that referenced this pull request Feb 13, 2025
@rschu1ze
Follow-up to ClickHouse#75470, ClickHouse#75756, ClickHouse#66143
1095ccf
@novikd novikd mentioned this pull request Feb 13, 2025
Merged
1 task
@CurtizJ CurtizJ mentioned this pull request Feb 14, 2025
Closed
github-merge-queue bot pushed a commit that referenced this pull request Feb 17, 2025
@rschu1ze
Merge pull request #76082 from rschu1ze/follow-up
4722e90 
Follow-up to #75470, #75756, #66143, #75671
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created-cloud deprecated label, NOOP label Feb 20, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 20, 2025
@ei-grad
Copy link
Copy Markdown
Contributor

ei-grad commented Mar 27, 2025

From the list of cherry-pick references, I guess that this is missed from 24.10.x for some reason?

@novikd
Copy link
Copy Markdown
Member Author

novikd commented Mar 27, 2025

@ei-grad We backport fixes only to LTS and the two last releases. That's why a cherry-pick to 24.10 was not created. Anyway, this fix was not backported to any previous version because it has too many conflicts, and resolving them takes a lot of effort and produces risks.

@novikd novikd mentioned this pull request Apr 3, 2025
Closed
@jkartseva jkartseva mentioned this pull request Apr 18, 2025
Merged
1 task
@novikd novikd mentioned this pull request Jun 17, 2025
Open
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jul 2, 2025
@nikitamikhaylov nikitamikhaylov mentioned this pull request Jul 24, 2025
Closed
@novikd novikd mentioned this pull request Aug 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devcrafter devcrafter devcrafter left review comments

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

analyzer Issues and pull-requests related to new analyzer pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

10 participants

@novikd @robot-clickhouse-ci-1 @alexey-milovidov @ei-grad @devcrafter @KochetovNicolai @robot-clickhouse @robot-ch-test-poll3 @robot-clickhouse-ci-2 @maxknv