Skip to content

Do not use default ReadSettings in readFile (use context->getReadSettings())#65625

Merged
kssenii merged 28 commits intomasterfrom
fix-read-settings-in-index-loading
Sep 27, 2024
Merged

Do not use default ReadSettings in readFile (use context->getReadSettings())#65625
kssenii merged 28 commits intomasterfrom
fix-read-settings-in-index-loading

Conversation

@kssenii
Copy link
Copy Markdown
Member

@kssenii kssenii commented Jun 24, 2024 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix ReadSettings not using user set values, because defaults were only used.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-improvement Pull request with some product improvements label Jun 24, 2024
@robot-ch-test-poll2
Copy link
Copy Markdown
Contributor

robot-ch-test-poll2 commented Jun 24, 2024 •
edited by robot-clickhouse-ci-2
Loading

This is an automated comment for commit ec8cf03 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@nikitamikhaylov nikitamikhaylov self-assigned this Jun 24, 2024
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Jun 24, 2024

Test?

@kssenii kssenii force-pushed the fix-read-settings-in-index-loading branch from 4e424fd to 5252ca5 Compare July 3, 2024 16:01
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Aug 6, 2024

Dear @nikitamikhaylov, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself.

@kssenii kssenii force-pushed the fix-read-settings-in-index-loading branch from e526958 to ecee872 Compare August 12, 2024 12:39
@kssenii kssenii changed the title Do not use default ReadSettings (use context->getReadSettings() everywhere instead) Do not use default ReadSettings in readFile (use context->getReadSettings()) Sep 18, 2024
@kssenii kssenii added this pull request to the merge queue Sep 27, 2024
Merged via the queue into master with commit 024e0b1 Sep 27, 2024
@kssenii kssenii deleted the fix-read-settings-in-index-loading branch September 27, 2024 13:17
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 27, 2024
baibaichen added a commit to Kyligence/gluten that referenced this pull request Sep 28, 2024
@baibaichen
Fix build due to ClickHouse/ClickHouse#65625
cc6995e
baibaichen added a commit to apache/gluten that referenced this pull request Sep 28, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240928) (#7379)
e29946d 
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240928)

* Fix build due to ClickHouse/ClickHouse#65625

* Fix build due to ClickHouse/ClickHouse#68410

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
@kssenii kssenii mentioned this pull request Oct 2, 2024
Merged
21 tasks
sharkdtu pushed a commit to sharkdtu/gluten that referenced this pull request Nov 11, 2024
@kyligence-git @baibaichen
[GLUTEN-1632][CH]Daily Update Clickhouse Version (20240928) (apache#7379
35a5186 
)

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240928)

* Fix build due to ClickHouse/ClickHouse#65625

* Fix build due to ClickHouse/ClickHouse#68410

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikitamikhaylov nikitamikhaylov nikitamikhaylov approved these changes

Assignees

@nikitamikhaylov nikitamikhaylov

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kssenii @robot-ch-test-poll2 @nikitamikhaylov @robot-clickhouse-ci-2