Fix AWS ECS by alexey-milovidov · Pull Request #65164 · ClickHouse/ClickHouse

alexey-milovidov · 2024-06-12T12:09:51Z

This was reverted

Changelog category (leave one):

Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

This change was reverted

CI Settings (Only check the boxes if you know what you are doing):

Exclude: Style check
Exclude: Fast test
Exclude: All with ASAN
Exclude: All with TSAN, MSAN, UBSAN, Coverage
Exclude: All with aarch64, release, debug

Do not test
Upload binaries for special builds
Disable merge-commit
Disable CI cache

alexey-milovidov · 2024-06-12T12:10:36Z

src/Common/ProxyConfigurationResolverProvider.cpp

        return protocol_prefix;
    }

-    template <bool new_syntax>


These were idiotic templates but not related to the issue.

alexey-milovidov · 2024-06-12T12:11:18Z

src/IO/S3/Credentials.h

 {

 inline static constexpr uint64_t DEFAULT_EXPIRATION_WINDOW_SECONDS = 120;
-inline static constexpr uint64_t DEFAULT_CONNECT_TIMEOUT_MS = 1000;


Unused variables.

robot-clickhouse · 2024-06-12T12:11:21Z

This is an automated comment for commit d9c4a3b with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check name	Description	Status
A Sync	If it fails, ask a maintainer for help	⏳ pending
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	❌ failure
Mergeable Check	Checks if all other necessary checks are successful	❌ failure
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

Successful checks

Check name	Description	Status
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Docs check	Builds and tests the documentation	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
PR Check	Checks correctness of the PR's body	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Style check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success

alexey-milovidov · 2024-06-12T12:11:31Z

src/IO/S3/Client.cpp

 {
    auto context = Context::getGlobalContextInstance();
    chassert(context);
-    auto proxy_configuration_resolver = DB::ProxyConfigurationResolverProvider::get(DB::ProxyConfiguration::protocolFromString(protocol), context->getConfigRef());


Extraneous namespace qualification.

alexey-milovidov · 2024-06-12T12:11:57Z

src/IO/S3/PocoHTTPClientFactory.cpp

 std::shared_ptr<Aws::Http::HttpClient>
 PocoHTTPClientFactory::CreateHttpClient(const Aws::Client::ClientConfiguration & client_configuration) const
 {
-    return std::make_shared<PocoHTTPClient>(static_cast<const PocoHTTPClientConfiguration &>(client_configuration));


The bug is here.

…e AWS SDK

This reverts commit 642dc35.

This reverts commit 20ca8f8.

tavplubix · 2024-06-17T21:11:57Z

@Avogar, it breaks CI, please resubmit

Avogar · 2024-06-17T21:25:27Z

@Avogar, it breaks CI, please resubmit

Can you share what is broken?

UPD: A Sync, now I see. It wasn't red and I didn't notice it. My fault. I will resubmit it

tavplubix · 2024-06-17T21:50:21Z

UPD: A Sync, now I see. It wasn't red and I didn't notice it

Yes, there's a bug in A Sync status that makes it yellow when it's actually red, so yellow is worth attention too, but it's not obvious. cc: @maxknv

jakedaleweb · 2024-06-17T22:33:30Z

Hi team. Thanks so much for addressing this, I am very keen to test it out. Please let me know when there is a container build I can use. It looks like head-alpine is currently a few commits behind this one.

jakedaleweb · 2024-06-18T03:13:26Z

Hello, seeing segmentation faults with this in-place still

18 June 2024 at 14:56 (UTC+12:00)
2024.06.18 02:56:03.241077 [ 57 ] {} <Fatal> Application: Child process was terminated by signal 11.
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:58.098447 [ 715 ] {} <Fatal> BaseDaemon: Integrity check of the executable successfully passed (checksum: C151D080117C79E61B8F56759CC284F0)
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:58.098656 [ 715 ] {} <Information> SentryWriter: Not sending crash report
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:58.098754 [ 715 ] {} <Fatal> BaseDaemon: Report this error to https://github.com/ClickHouse/ClickHouse/issues
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:57.735008 [ 715 ] {} <Fatal> BaseDaemon: (version 24.6.1.4010 (official build), build id: FF9078AF95645BE01B16663A1B04A9FF803EA617, git hash: 856f5c395a5db5a577e928000da18506f2ac0c42) (from thread 60) (no query) Received signal Segmentation fault (11)
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:57.735051 [ 715 ] {} <Fatal> BaseDaemon: Address: 0x322bcb0. Access: read. Attempted access has violated the permissions assigned to the memory area.
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:57.735096 [ 715 ] {} <Fatal> BaseDaemon: Stack trace: 0x000000000d25d72c 0x00007f0e7274b420
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:57.735162 [ 715 ] {} <Fatal> BaseDaemon: 0. signalHandler(int, siginfo_t*, void*) @ 0x000000000d25d72c
pollution-atomic-1-clickhouse-fargate
18 June 2024 at 14:55 (UTC+12:00)
2024.06.18 02:55:57.735203 [ 715 ] {} <Fatal> BaseDaemon: 1. ? @ 0x00007f0e7274b420

Using the following configuration

<clickhouse>
    <logger>
      <level>information</level>
      <console>true</console>
    </logger>
    <storage_configuration>
      <disks>
        <s3_disk>
          <type>s3</type>
          <endpoint from_env="CLICKHOUSE_BACKEND_BUCKET"/>
          <use_environment_credentials>true</use_environment_credentials>
          <metadata_path>/var/lib/clickhouse/disks/s3_disk/</metadata_path>
        </s3_disk>
        <s3_cache>
          <type>cache</type>
          <disk>s3_disk</disk>
          <path>/var/lib/clickhouse/disks/s3_cache/</path>
          <max_size>10Gi</max_size>
        </s3_cache>
      </disks>
      <policies>
        <s3_main>
          <volumes>
            <main>
              <disk>s3_disk</disk>
            </main>
          </volumes>
        </s3_main>
      </policies>
    </storage_configuration>
</clickhouse>

alexey-milovidov · 2024-06-18T07:20:07Z

@jakedaleweb, it is not merged.

jakedaleweb · 2024-06-18T21:50:48Z

ah sorry! getting ahead of myself

Sharu95 · 2024-06-20T10:24:18Z

Is this fix continued somewhere else?

Avogar · 2024-06-20T11:21:48Z

Here is the resubmit: #65362

alexey-milovidov · 2024-06-20T12:48:28Z

@Sharu95, we found two bugs in the AWS SDK - it is incompatible with C++23, it is not memory safe 😆 and has data races. Pending fixes.

Fix AWS ECS

89d2de2

alexey-milovidov commented Jun 12, 2024

View reviewed changes

robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Jun 12, 2024

alexey-milovidov commented Jun 12, 2024

View reviewed changes

Add a test

a32df98

alexey-milovidov marked this pull request as ready for review June 12, 2024 12:19

serxa self-assigned this Jun 12, 2024

serxa approved these changes Jun 13, 2024

View reviewed changes

alexey-milovidov added 3 commits June 16, 2024 09:00

Merge branch 'master' into ecs

c3bd1be

Rename tests

a6ff094

Fix alloc/dealloc mismatch or prevent false-positive ASan error in th…

cb390cc

…e AWS SDK

robot-clickhouse-ci-2 added the submodule changed At least one submodule changed in this PR. label Jun 16, 2024

alexey-milovidov added 5 commits June 16, 2024 15:20

Debug AWS

20ca8f8

Debug AWS

642dc35

Fix error

37eb815

Revert "Debug AWS"

b41bb96

This reverts commit 642dc35.

Revert "Debug AWS"

2c19189

This reverts commit 20ca8f8.

alexey-milovidov mentioned this pull request Jun 16, 2024

Fix ASan report about alloc/dealloc mismatch when compiled with C++23 awslabs/aws-crt-cpp#629

Closed

alexey-milovidov added 4 commits June 16, 2024 17:32

Version in User-Agent

35ce8c6

Slightly better user-agent

8b1f194

Merge branch 'master' into ecs

cf0e578

Merge branch 'master' into ecs

d9c4a3b

Avogar added this pull request to the merge queue Jun 17, 2024

Merged via the queue into master with commit 903b09b Jun 17, 2024

Avogar deleted the ecs branch June 17, 2024 19:14

tavplubix mentioned this pull request Jun 17, 2024

Revert "Fix AWS ECS" #65361

Merged

robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 17, 2024

Algunenano added pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-bugfix Pull request with bugfix, not backported by default labels Jun 20, 2024

Conversation

alexey-milovidov commented Jun 12, 2024 • edited by Algunenano Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

CI Settings (Only check the boxes if you know what you are doing):

Uh oh!

alexey-milovidov Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

alexey-milovidov Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

robot-clickhouse commented Jun 12, 2024 • edited by robot-clickhouse-ci-1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

alexey-milovidov Jun 12, 2024

Choose a reason for hiding this comment

Uh oh!

tavplubix commented Jun 17, 2024

Uh oh!

Avogar commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tavplubix commented Jun 17, 2024

Uh oh!

jakedaleweb commented Jun 17, 2024

Uh oh!

jakedaleweb commented Jun 18, 2024

Uh oh!

alexey-milovidov commented Jun 18, 2024

Uh oh!

jakedaleweb commented Jun 18, 2024

Uh oh!

Sharu95 commented Jun 20, 2024

Uh oh!

Avogar commented Jun 20, 2024

Uh oh!

alexey-milovidov commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

alexey-milovidov commented Jun 12, 2024 •

edited by Algunenano

Loading

robot-clickhouse commented Jun 12, 2024 •

edited by robot-clickhouse-ci-1

Loading

Avogar commented Jun 17, 2024 •

edited

Loading