Skip to content

Fix possible crash with SYSTEM UNLOAD PRIMARY KEY#63778

Merged
Algunenano merged 4 commits intoClickHouse:masterfrom
Algunenano:crash_unload
May 16, 2024
Merged

Fix possible crash with SYSTEM UNLOAD PRIMARY KEY#63778
Algunenano merged 4 commits intoClickHouse:masterfrom
Algunenano:crash_unload

Conversation

@Algunenano
Copy link
Copy Markdown
Member

@Algunenano Algunenano commented May 14, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  • Fix possible crash with SYSTEM UNLOAD PRIMARY KEY

A combination of SYSTEM UNLOAD PRIMARY KEY table and ALTER TABLE t MODIFY SETTING primary_key_ratio_of_unique_prefix_values_to_skip_suffix_columns could crash the server.

Also, change the getIndex() API to something less error-prone. The fact that we had TSA_SUPPRESS_WARNING_FOR_READ was a smell, since it meant we had to trust the caller to not modify the contents of the pointer. Let's see if the CI agrees (it seems it was a compiler version specific warning).

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step

Include tests (required builds will be added automatically):

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Unit tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with Analyzer
  • All with Azure
  • Add your option here

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • Add your option here

Extra options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@Algunenano Algunenano added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label May 14, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-bugfix Pull request with bugfix, not backported by default label May 14, 2024
@robot-ch-test-poll4
Copy link
Copy Markdown
Contributor

robot-ch-test-poll4 commented May 14, 2024 •
edited by robot-clickhouse-ci-1
Loading

This is an automated comment for commit fc5961e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS❌ failure
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@Algunenano Algunenano mentioned this pull request May 14, 2024
Merged
1 task
Algunenano
Algunenano commented May 14, 2024
View reviewed changes
@tavplubix tavplubix self-assigned this May 14, 2024
@Algunenano
Copy link
Copy Markdown
Member Author

Algunenano commented May 16, 2024

Bugfix validation — New test(s) failed to reproduce a bug

It's not easily reproducible in release mode since it involves not only using no longer valid values but then crashing. It reproduces fine in debug since there is an assert being triggered.

Stateless tests (debug, s3 storage) [4/6]

Unrelated

@Algunenano Algunenano added this pull request to the merge queue May 16, 2024
Merged via the queue into ClickHouse:master with commit e1389c1 May 16, 2024
@Algunenano Algunenano deleted the crash_unload branch May 16, 2024 11:48
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 16, 2024
This was referenced May 16, 2024
Closed
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request May 16, 2024
@robot-clickhouse
Backport #63778 to 24.4: Fix possible crash with SYSTEM UNLOAD PRIMAR…
880dd62 
…Y KEY
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request May 16, 2024
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label May 16, 2024
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created-cloud deprecated label, NOOP label May 16, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request May 16, 2024
@robot-clickhouse-ci-1
Merge pull request #63955 from ClickHouse/backport/24.4/63778
7a27a3c 
Backport #63778 to 24.4: Fix possible crash with SYSTEM UNLOAD PRIMARY KEY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tavplubix tavplubix tavplubix approved these changes

Assignees

@tavplubix tavplubix

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Algunenano @robot-ch-test-poll4 @tavplubix @robot-ch-test-poll1 @robot-ch-test-poll3 @robot-clickhouse-ci-2