Skip to content

fix logical-error when undoing quorum insert transaction#61953

Merged
hanfei1991 merged 4 commits intoClickHouse:masterfrom
hanfei1991:hanfei/fix-quorum-retry
Mar 28, 2024
Merged

fix logical-error when undoing quorum insert transaction#61953
hanfei1991 merged 4 commits intoClickHouse:masterfrom
hanfei1991:hanfei/fix-quorum-retry

Conversation

@hanfei1991
Copy link
Copy Markdown
Member

@hanfei1991 hanfei1991 commented Mar 26, 2024

See https://github.com/ClickHouse/clickhouse-core-incidents/issues/68

This bug is:

  • server 2 do quorum insert, got connection loss when writing keeper, but keeper has the record
  • server 1 see the log, but does not see the part, because server 2 is read-only. then server 1 set this part as quorum/failed_part
  • keeper recovered
  • server 2 wake up, the restarting thread see oh my god there are quorum/failed_part let's clean them
  • writing thread is checking keeper node, found nothing, decide to retry
  • before retry, transaction need to rollback and clean parts
  • when clean parts, it sees no parts because it has been cleaned by restarting thread, report LOGICAL_ERROR

solution
in retry logic, if we see quorum/failed_part / part_name exists, do nothing, because restarting thread will clean it.

Sorry that I have not tested it, the logic is complex :( will do it slowly

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

fix logical-error when undoing quorum insert transaction

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

Modify your CI run:

NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Set desired options before CI starts or re-push after updates

Run only:

  • Integration tests
  • Integration tests (arm64)
  • Stateless tests (release)
  • Stateless tests (asan)
  • Stateful tests (release)
  • Stateful tests (asan)
  • No sanitizers
  • Tests with analyzer
  • Fast tests
  • Only package_debug build
  • Add your CI variant description here

CI options:

  • do not test (only style check)
  • disable merge-commit (no merge from master before tests)
  • disable CI cache (job reuse)

Only specified batches in multi-batch jobs:

  • 1
  • 2
  • 3
  • 4

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Mar 26, 2024
@robot-clickhouse
Copy link
Copy Markdown
Member

robot-clickhouse commented Mar 26, 2024 •
edited
Loading

This is an automated comment for commit 15566f6 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@CheSema CheSema self-assigned this Mar 27, 2024
@hanfei1991 hanfei1991 marked this pull request as ready for review March 27, 2024 17:56
@hanfei1991
Copy link
Copy Markdown
Member Author

hanfei1991 commented Mar 28, 2024

@CheSema PTAL

CheSema
CheSema approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@CheSema CheSema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually cool work with fail points.

@hanfei1991 hanfei1991 merged commit 419ac38 into ClickHouse:master Mar 28, 2024
@hanfei1991 hanfei1991 deleted the hanfei/fix-quorum-retry branch March 28, 2024 19:49
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 28, 2024
@antaljanosbenjamin antaljanosbenjamin added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label May 23, 2024
This was referenced May 23, 2024
Closed
Merged
robot-clickhouse added a commit that referenced this pull request May 23, 2024
@robot-clickhouse
Backport #61953 to 24.2: fix logical-error when undoing quorum insert…
6692670 
… transaction
This was referenced May 23, 2024
Merged
Merged
robot-clickhouse added a commit that referenced this pull request May 23, 2024
@robot-clickhouse
Backport #61953 to 24.3: fix logical-error when undoing quorum insert…
b961865 
… transaction
@robot-ch-test-poll4 robot-ch-test-poll4 mentioned this pull request May 23, 2024
Merged
robot-ch-test-poll added a commit that referenced this pull request May 23, 2024
@robot-ch-test-poll
Merge pull request #64288 from ClickHouse/backport/24.2/61953
58f1bac 
Backport #61953 to 24.2: fix logical-error when undoing quorum insert transaction
robot-ch-test-poll2 added a commit that referenced this pull request May 23, 2024
@robot-ch-test-poll2
Merge pull request #64290 from ClickHouse/backport/24.3/61953
59fca61 
Backport #61953 to 24.3: fix logical-error when undoing quorum insert transaction
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label May 27, 2024
@robot-clickhouse robot-clickhouse added the pr-backports-created-cloud deprecated label, NOOP label May 29, 2024
@azat azat mentioned this pull request Mar 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CheSema CheSema CheSema approved these changes

Assignees

@CheSema CheSema

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-improvement Pull request with some product improvements pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hanfei1991 @robot-clickhouse @CheSema @antaljanosbenjamin @robot-ch-test-poll @robot-ch-test-poll1