Skip to content

Fix fuzzer failure in ActionsDAG#51301

Merged
KochetovNicolai merged 1 commit intomasterfrom
fix-fuzz-actions-dag
Jun 23, 2023
Merged

Fix fuzzer failure in ActionsDAG#51301
KochetovNicolai merged 1 commit intomasterfrom
fix-fuzz-actions-dag

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jun 22, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

It was possible to construct a query triggering nullptr dereference during the condition pushdown optimization. This closes #50451

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-bugfix Pull request with bugfix, not backported by default label Jun 22, 2023
@robot-clickhouse-ci-2
Copy link
Copy Markdown
Contributor

robot-clickhouse-ci-2 commented Jun 22, 2023 •
edited by robot-ch-test-poll
Loading

This is an automated comment for commit c958a1a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@alexey-milovidov alexey-milovidov added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Jun 23, 2023
@KochetovNicolai KochetovNicolai self-assigned this Jun 23, 2023
@KochetovNicolai
Copy link
Copy Markdown
Member

KochetovNicolai commented Jun 23, 2023

Integration tests (tsan) : #45404

@KochetovNicolai KochetovNicolai merged commit e44b544 into master Jun 23, 2023
@KochetovNicolai KochetovNicolai deleted the fix-fuzz-actions-dag branch June 23, 2023 10:30
This was referenced Jun 23, 2023
Merged
Merged
Merged
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Jun 23, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jun 23, 2023
@robot-clickhouse
Backport #51301 to 23.5: Fix fuzzer failure in ActionsDAG
374c1a8
@qoega qoega mentioned this pull request Jun 23, 2023
Merged
1 task
alexey-milovidov added a commit that referenced this pull request Jun 24, 2023
@alexey-milovidov
Merge pull request #51319 from ClickHouse/backport/23.5/51301
f40f609 
Backport #51301 to 23.5: Fix fuzzer failure in ActionsDAG
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Jun 27, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jun 27, 2023
@robot-clickhouse
Backport #51301 to 22.8: Fix fuzzer failure in ActionsDAG
ef44c78
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Jun 27, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jun 27, 2023
@robot-clickhouse
Backport #51301 to 23.3: Fix fuzzer failure in ActionsDAG
e80a7ec
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Jun 27, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Jun 27, 2023
@robot-clickhouse
Backport #51301 to 23.4: Fix fuzzer failure in ActionsDAG
005f1d0
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 27, 2023
KochetovNicolai added a commit that referenced this pull request Jun 29, 2023
@KochetovNicolai
Merge pull request #51489 from ClickHouse/backport/22.8/51301
8572b1e 
Backport #51301 to 22.8: Fix fuzzer failure in ActionsDAG
KochetovNicolai added a commit that referenced this pull request Jun 29, 2023
@KochetovNicolai
Merge pull request #51490 from ClickHouse/backport/23.3/51301
bc683c1 
Backport #51301 to 23.3: Fix fuzzer failure in ActionsDAG
KochetovNicolai added a commit that referenced this pull request Jun 29, 2023
@KochetovNicolai
Merge pull request #51491 from ClickHouse/backport/23.4/51301
0ced5d6 
Backport #51301 to 23.4: Fix fuzzer failure in ActionsDAG
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created-cloud deprecated label, NOOP label Jun 29, 2023
MyroTk pushed a commit to Altinity/ClickHouse that referenced this pull request Sep 21, 2023
@robot-clickhouse @MyroTk
Backport ClickHouse#51301 to 23.3: Fix fuzzer failure in ActionsDAG
a7806ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees

@KochetovNicolai KochetovNicolai

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud deprecated label, NOOP pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

segfault src/Interpreters/ActionsDAG.cpp:2144

4 participants

@alexey-milovidov @robot-clickhouse-ci-2 @KochetovNicolai @robot-ch-test-poll2