Merged
Conversation
Contributor
|
This is an automated comment for commit 783b546 with description of existing statuses. It's updated for the latest CI running
|
1786461 to
8d901eb
Compare
vdimir
added a commit
that referenced
this pull request
May 10, 2023
novikd
reviewed
May 11, 2023
|
|
||
| static std::optional<JoinTableSide> getColumnSideFromJoinTree(QueryTreeNodePtr & resolved_identifier, const JoinNode & join_node) | ||
| { | ||
| const auto * column_src = resolved_identifier->as<ColumnNode &>().getColumnSource().get(); |
Member
Author
There was a problem hiding this comment.
Yes, it can be SELECT ta.t.* FROM ta FULL JOIN tb USING (t.t.t); where ta.t is nested.
I added handling to this function in this PR , but will add test in #49703 , because without tat fix it will be fail in other place
2 tasks
8208a27 to
473cb04
Compare
novikd
reviewed
May 30, 2023
Comment on lines
+4062
to
+4070
| const auto * nearest_query_scope = scope.getNearestQueryScope(); | ||
| const QueryNode * nearest_scope_query_node = nearest_query_scope ? nearest_query_scope->scope_node->as<QueryNode>() : nullptr; | ||
| const QueryTreeNodePtr & nearest_scope_join_tree = nearest_scope_query_node ? nearest_scope_query_node->getJoinTree() : nullptr; | ||
| const JoinNode * nearest_scope_join_node = nearest_scope_join_tree ? nearest_scope_join_tree->as<JoinNode>() : nullptr; |
Member
There was a problem hiding this comment.
I didn't understand what happened here. Please add a comment.
d6e8f48 to
783b546
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
join_use_nullsin analyzer.Matches were not handled. Also column is not nullable if it was resolved from both tables
@kitaisreal