Create core dir: dont crash if have no permissions#486
Merged
alexey-milovidov merged 9 commits intoClickHouse:masterfrom Feb 14, 2017
Merged
Create core dir: dont crash if have no permissions#486alexey-milovidov merged 9 commits intoClickHouse:masterfrom
alexey-milovidov merged 9 commits intoClickHouse:masterfrom
Conversation
alexey-milovidov
requested changes
Feb 13, 2017
libs/libdaemon/src/BaseDaemon.cpp
Outdated
| catch (const std::exception & e) | ||
| { | ||
| logger().warning("Cannot create core_path directory [ " + core_path + " ]" + " what(): " + e.what()); | ||
| } |
Member
There was a problem hiding this comment.
Why catching just std::exception? Please note, that what() of std::exception will contain only exception name without descriptive message.
Double whitespace before core_path.
Why you embed path in square brackets and why there is padding with whitespace inside?
libs/libdaemon/src/BaseDaemon.cpp
Outdated
| Poco::File(core_path).createDirectories(); | ||
| try | ||
| { | ||
| Poco::File(core_path).createDirectories(); |
Member
There was a problem hiding this comment.
Why not to define static void tryCreateDirectories.
loneylee
pushed a commit
to loneylee/ClickHouse
that referenced
this pull request
Mar 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.