Skip to content

Fix SAMPLE BY with Merge tables#43315

Merged
antonio2368 merged 4 commits intomasterfrom
fix-merge-sample-by
Nov 21, 2022
Merged

Fix SAMPLE BY with Merge tables#43315
antonio2368 merged 4 commits intomasterfrom
fix-merge-sample-by

Conversation

@antonio2368
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed queries with SAMPLE BY with prewhere optimization on tables using Merge engine.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@KochetovNicolai KochetovNicolai self-assigned this Nov 17, 2022
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for now.
I need to fix it in a different way.

@antonio2368
Copy link
Copy Markdown
Member Author

@KochetovNicolai I agree it's an ad hoc solution but couldn't figure another way to do it easily.
I'll backport this also.

@antonio2368 antonio2368 added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 17, 2022
@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 17, 2022
@antonio2368 antonio2368 merged commit af647ba into master Nov 21, 2022
@antonio2368 antonio2368 deleted the fix-merge-sample-by branch November 21, 2022 08:09
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 21, 2022
antonio2368 added a commit that referenced this pull request Nov 23, 2022
Backport #43315 to 22.8: Fix `SAMPLE BY` with Merge tables
antonio2368 added a commit that referenced this pull request Nov 23, 2022
Backport #43315 to 22.9: Fix `SAMPLE BY` with Merge tables
antonio2368 added a commit that referenced this pull request Nov 23, 2022
Backport #43315 to 22.10: Fix `SAMPLE BY` with Merge tables
antonio2368 added a commit that referenced this pull request Nov 23, 2022
Backport #43315 to 22.11: Fix `SAMPLE BY` with Merge tables
antonio2368 added a commit that referenced this pull request Nov 24, 2022
Backport #43315 to 22.3: Fix `SAMPLE BY` with Merge tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants